From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Received: (qmail 4094 invoked from network); 11 Nov 2002 23:42:49 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 11 Nov 2002 23:42:49 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gABNJkw10836 for ; Mon, 11 Nov 2002 18:19:46 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gABNgmD32411; Mon, 11 Nov 2002 18:42:48 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gABNgkq06044; Mon, 11 Nov 2002 18:42:46 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id D9B66FF79; Mon, 11 Nov 2002 18:38:36 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15824.16252.683116.625849@localhost.redhat.com> Date: Mon, 11 Nov 2002 17:15:00 -0000 To: David Carlton Cc: Elena Zannoni , gdb-patches@sources.redhat.com, Fernando Nasser , Jim Blandy Subject: Re: [rfa] linespec.c, part 3 In-Reply-To: References: <15824.12061.128364.623571@localhost.redhat.com> X-SW-Source: 2002-11/txt/msg00334.txt.bz2 David Carlton writes: > On Mon, 11 Nov 2002 17:28:45 -0500, Elena Zannoni said: > > David Carlton writes: > > >> This part of the decode_line_1 refactoring moves some code > >> initializing some flags into a separate function set_flags. Some > >> comments: > > > Looks ok, but I have a question. Wouldn't the code that sets up > > has_comma and is_quote_enclosed also belong to this set_flags > > function? > > It seems entirely plausible to me that that is the case. For now, > that will come in my next patch, which won't quite do what you ask: > the problem is that that part of the code is also updating 'p' to > figure out where a compound linespec separator is (for filenames or > C++/Java objects). Teasing this apart is a bit of a mess; my current > "final" version of these changes has 'has_comma' buried in an internal > function, and 'is_quote_enclosed' doesn't last for very long. But > it's messy, so I think that, once I'm done submitting patches that > just break off code into separate functions, we should revisit this > issue. > Yes, I didn't really think the issue through. > > (Ideally a struct of flags could be set up). > > Yes, that would be a much better idea than passing the flag variables > by reference. > > > But this is for a separate patch, you are just moving code around > > now. > > Right. > > > go ahead, thanks! > > Committed. > > (Now you've caught up to me! Eek! I'll have to get my grading done > quickly so I can keep up my end of things. :-) ) > Don't worry, I have plenty of other things to do myself! Elena > David Carlton > carlton@math.stanford.edu