From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15623 invoked by alias); 6 Nov 2002 18:16:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15463 invoked from network); 6 Nov 2002 18:16:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 6 Nov 2002 18:16:01 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gA6HrLw11608 for ; Wed, 6 Nov 2002 12:53:21 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gA6IFvf04214; Wed, 6 Nov 2002 13:15:57 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gA6IEZT01048; Wed, 6 Nov 2002 13:14:35 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 15B37FF79; Wed, 6 Nov 2002 13:09:06 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15817.23234.419911.464165@localhost.redhat.com> Date: Wed, 06 Nov 2002 10:16:00 -0000 To: Pierre Muller Cc: Daniel Jacobowitz , Elena Zannoni , Andrew Cagney , fnasser@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] cli-out.c new function In-Reply-To: <5.0.2.1.2.20021106094824.02b66088@ics.u-strasbg.fr> References: <15816.21181.748534.54828@localhost.redhat.com> <5.0.2.1.2.20021106094824.02b66088@ics.u-strasbg.fr> X-SW-Source: 2002-11/txt/msg00106.txt.bz2 Pierre Muller writes: > At 04:26 06/11/2002, Daniel Jacobowitz wrote: > >On Tue, Nov 05, 2002 at 06:22:37PM -0500, Elena Zannoni wrote: > >> > >> This function sets the stream of the uiout file to the given > >> parameter. It is used in the interpreter work. Maybe Keith or JimI > >> can explain this a bit better, but switching interpreters can change > >> the gdb_sdout. > >> > >> > >> /* gdb_stdout could change between the time cli_uiout was initialized > >> and now. Since we're probably using a different interpreter which has > >> a new ui_file for gdb_stdout, use that one instead of the default. > >> > >> It is important that it gets reset everytime, since the user could > >> set gdb to use a different interpreter. */ > >> old_stream = cli_out_set_stream (cli_uiout, gdb_stdout); > > > >Something (two things actually) very much like this were discussed and > >we never reached agreement on them. See my patch for a `tee' command > >and file redirection; and something similar from Pierre. A couple of > >months ago now. > > See the following threads: > [RFC/RFA] avoid spurious Watchpoint X output on cygwin native target. > http://sources.redhat.com/ml/gdb-patches/2002-07/msg00323.html > > and > RFA: Make cli-out follow gdb_stdout > http://sources.redhat.com/ml/gdb-patches/2002-07/msg00366.html > as well as > (which is a different thread, probably because I didn't use Relpy...) > http://sources.redhat.com/ml/gdb-patches/2002-08/msg00549.html > > But honestly, I don't know if the this new function solves the > problem... Ulgh, we seem to have hit a wall. I see that the same concerns about your solutions apply to this one. I guess that in my case using catch_exception should work, because the current code does this: old_stream = cli_out_set_stream (cli_uiout, gdb_stdout); result = safe_execute_command (cli_uiout, command_str, 1); cli_out_set_stream (cli_uiout, old_stream); I could change that into a catch_exceptions call. In fact, safe_execute_command *IS* a wrapper around catch_exceptions already. The general problem is not solved, however. Elena > IMHO, standard gdb sources should not have to worry at all about > the possible fact that an interpreter is present... > The fact that standard gdb code redirects gdb_stdout (or gdb_stderr) > should be respected by any interpreter, no? > Thus I still think that the best solution is the double pointer one... > but Andrew is stronly opposed to that solution.... > > > Pierre Muller > Institut Charles Sadron > 6,rue Boussingault > F 67083 STRASBOURG CEDEX (France) > mailto:muller@ics.u-strasbg.fr > Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99