From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7780 invoked by alias); 6 Nov 2002 03:45:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7772 invoked from network); 6 Nov 2002 03:45:24 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 6 Nov 2002 03:45:24 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gA63Mow25258 for ; Tue, 5 Nov 2002 22:22:50 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gA63jNf20611 for ; Tue, 5 Nov 2002 22:45:23 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gA63jMT30787 for ; Tue, 5 Nov 2002 22:45:22 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 6E66FFF79; Tue, 5 Nov 2002 22:35:11 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15816.36335.124501.342414@localhost.redhat.com> Date: Tue, 05 Nov 2002 19:45:00 -0000 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Move _initialize_hppa_tdep to the end of file In-Reply-To: <20021106022555.GN5164@gnat.com> References: <20021106022555.GN5164@gnat.com> X-SW-Source: 2002-11/txt/msg00090.txt.bz2 Joel Brobecker writes: > I'd like more _initialize_hppa_tdep to the end of the file. This is not > absolutely needed, but it conforms a bit better with the practice I've > seen used for other targets. If nobody objects, I'd like to check this > in tomorrow. Sure. Actually multiarching a target is considered an obvious activity, so you have the option of just post patches, instead of RFA's. For instance see the multiarching of the h8300 (please do it with incremental patches). Elena > > A patch to add the gdbarch framework will shortly follow the checkin. > > 2002-11-05 Joel Brobecker > > * hppa-tdep.c (_initialize_hppa_tdep): Move function body > to end of file, to be more consistent with the pratice followed > in other targets. > > -- > Joel > Index: hppa-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/hppa-tdep.c,v > retrieving revision 1.29 > diff -c -3 -p -r1.29 hppa-tdep.c > *** hppa-tdep.c 30 Oct 2002 20:42:54 -0000 1.29 > --- hppa-tdep.c 6 Nov 2002 02:18:50 -0000 > *************** hppa_skip_permanent_breakpoint (void) > *** 4674,4724 **** > /* We can leave the tail's space the same, since there's no jump. */ > } > > - void > - _initialize_hppa_tdep (void) > - { > - struct cmd_list_element *c; > - void break_at_finish_command (char *arg, int from_tty); > - void tbreak_at_finish_command (char *arg, int from_tty); > - void break_at_finish_at_depth_command (char *arg, int from_tty); > - > - tm_print_insn = print_insn_hppa; > - > - add_cmd ("unwind", class_maintenance, unwind_command, > - "Print unwind table entry at given address.", > - &maintenanceprintlist); > - > - deprecate_cmd (add_com ("xbreak", class_breakpoint, > - break_at_finish_command, > - concat ("Set breakpoint at procedure exit. \n\ > - Argument may be function name, or \"*\" and an address.\n\ > - If function is specified, break at end of code for that function.\n\ > - If an address is specified, break at the end of the function that contains \n\ > - that exact address.\n", > - "With no arg, uses current execution address of selected stack frame.\n\ > - This is useful for breaking on return to a stack frame.\n\ > - \n\ > - Multiple breakpoints at one place are permitted, and useful if conditional.\n\ > - \n\ > - Do \"help breakpoints\" for info on other commands dealing with breakpoints.", NULL)), NULL); > - deprecate_cmd (add_com_alias ("xb", "xbreak", class_breakpoint, 1), NULL); > - deprecate_cmd (add_com_alias ("xbr", "xbreak", class_breakpoint, 1), NULL); > - deprecate_cmd (add_com_alias ("xbre", "xbreak", class_breakpoint, 1), NULL); > - deprecate_cmd (add_com_alias ("xbrea", "xbreak", class_breakpoint, 1), NULL); > - > - deprecate_cmd (c = add_com ("txbreak", class_breakpoint, > - tbreak_at_finish_command, > - "Set temporary breakpoint at procedure exit. Either there should\n\ > - be no argument or the argument must be a depth.\n"), NULL); > - set_cmd_completer (c, location_completer); > - > - if (xdb_commands) > - deprecate_cmd (add_com ("bx", class_breakpoint, > - break_at_finish_at_depth_command, > - "Set breakpoint at procedure exit. Either there should\n\ > - be no argument or the argument must be a depth.\n"), NULL); > - } > - > /* Copy the function value from VALBUF into the proper location > for a function return. > > --- 4674,4679 ---- > *************** hppa_extract_return_value (struct type * > *** 4768,4770 **** > --- 4723,4771 ---- > : (4 - TYPE_LENGTH (type)))), > TYPE_LENGTH (type)); > } > + > + void > + _initialize_hppa_tdep (void) > + { > + struct cmd_list_element *c; > + void break_at_finish_command (char *arg, int from_tty); > + void tbreak_at_finish_command (char *arg, int from_tty); > + void break_at_finish_at_depth_command (char *arg, int from_tty); > + > + tm_print_insn = print_insn_hppa; > + > + add_cmd ("unwind", class_maintenance, unwind_command, > + "Print unwind table entry at given address.", > + &maintenanceprintlist); > + > + deprecate_cmd (add_com ("xbreak", class_breakpoint, > + break_at_finish_command, > + concat ("Set breakpoint at procedure exit. \n\ > + Argument may be function name, or \"*\" and an address.\n\ > + If function is specified, break at end of code for that function.\n\ > + If an address is specified, break at the end of the function that contains \n\ > + that exact address.\n", > + "With no arg, uses current execution address of selected stack frame.\n\ > + This is useful for breaking on return to a stack frame.\n\ > + \n\ > + Multiple breakpoints at one place are permitted, and useful if conditional.\n\ > + \n\ > + Do \"help breakpoints\" for info on other commands dealing with breakpoints.", NULL)), NULL); > + deprecate_cmd (add_com_alias ("xb", "xbreak", class_breakpoint, 1), NULL); > + deprecate_cmd (add_com_alias ("xbr", "xbreak", class_breakpoint, 1), NULL); > + deprecate_cmd (add_com_alias ("xbre", "xbreak", class_breakpoint, 1), NULL); > + deprecate_cmd (add_com_alias ("xbrea", "xbreak", class_breakpoint, 1), NULL); > + > + deprecate_cmd (c = add_com ("txbreak", class_breakpoint, > + tbreak_at_finish_command, > + "Set temporary breakpoint at procedure exit. Either there should\n\ > + be no argument or the argument must be a depth.\n"), NULL); > + set_cmd_completer (c, location_completer); > + > + if (xdb_commands) > + deprecate_cmd (add_com ("bx", class_breakpoint, > + break_at_finish_at_depth_command, > + "Set breakpoint at procedure exit. Either there should\n\ > + be no argument or the argument must be a depth.\n"), NULL); > + } > +