From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15430 invoked by alias); 4 Nov 2002 00:09:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15380 invoked from network); 4 Nov 2002 00:09:28 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 4 Nov 2002 00:09:28 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gA3Nl7w07434 for ; Sun, 3 Nov 2002 18:47:07 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gA409Sf23704 for ; Sun, 3 Nov 2002 19:09:28 -0500 Received: from localhost.redhat.com (IDENT:zrsDYIcH6a/iMEcfdf+GssRunrOfbADO@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gA409PT24624; Sun, 3 Nov 2002 19:09:25 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id D5278FF79; Sun, 3 Nov 2002 19:05:17 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Message-ID: <15813.47549.125741.380864@localhost.redhat.com> Date: Sun, 03 Nov 2002 16:09:00 -0000 To: Pierre Muller Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix an error in value_change_enclosing_type In-Reply-To: <5.0.2.1.2.20021028150203.02ffe2c8@ics.u-strasbg.fr> References: <3.0.6.32.20021020235330.00c24478@ics.u-strasbg.fr> <5.0.2.1.2.20021007132114.01e66260@ics.u-strasbg.fr> <5.0.2.1.2.20021028150203.02ffe2c8@ics.u-strasbg.fr> X-SW-Source: 2002-11/txt/msg00027.txt.bz2 Pierre Muller writes: > A 22:39 22/10/2002, Elena Zannoni a =E9crit : > >muller@cerbere.u-strasbg.fr writes: > > > At 17:05 18/10/2002 -0400, Elena Zannoni wrote: > > > >Pierre Muller writes: > > > > >=20 > > > > >=20 > > > > >=20 > > > > > the function value_change_enclosing_type > > > > > does not set the enlclosing_type field correctly if > > > > > the new_encl_type has a bigger length that the value type. > > > > >=20 > > > > > Its seems quite astonishing that this has not been noticed befor= e,=20 > > > > > but I discovered it when trying to get=20 > > > > > the fpc-abi.c code to work correctly. > > > > >=20 > > > > > > > >The fix seems OK. However, do you have a small testcase? It would be > > > >good to add it to the testsuite. > > > Sorry, but I don't have any, because I really don't even know > > > if this code is ever executed for C code. It is for > > > Free Pascal generated code, that is how I discovered that bug. > > > But I can't add tests with Free Pascal anyhow. > > >=20 > > > >Oh, ok. > > > > > >Does this fix changes the results for the already existing tests? > > >=20 > > > Sorry, but I never worked with the testsuite, > > > so I can't answer this question. > > >=20 > > > >Could you run make check in your gdb/testsuite directory in the build > >tree? All I meant is, whether or not the test results are different > >before and after your change. > > > >thanks > >Elena >=20 >=20 > I tried to create a test program > using C++ code, but it does never seem to > use the code that I modified... >=20 > Thus, as I expected, the testsuite is unchanged: >=20 > Tested on a i386 linux box: > (note that pthreads libs is not installed on that machine, > which creates several failures) > cvs tree from 29/10/2002: >=20 There is on more pass with your patch, looks like. Which test passed? It could be a transient failure. Otherwise, ok. Elena > =3D=3D=3D gdb Summary =3D=3D=3D >=20 > # of expected passes 8235 > # of unexpected failures 52 > # of unexpected successes 10 > # of expected failures 168 > # of unresolved testcases 3 > # of untested testcases 9 > # of unsupported tests 4 > /home/pierre/gdb/build/origdb/testsuite/../../gdb/gdb version 2002-10-2= 9-cvs -nx >=20 > same cvs tree + my patch : >=20 >=20 > =3D=3D=3D gdb Summary =3D=3D=3D >=20 > # of expected passes 8236 > # of unexpected failures 51 > # of unexpected successes 10 > # of expected failures 168 > # of unresolved testcases 3 > # of untested testcases 9 > # of unsupported tests 4 > /home/pierre/gdb/build/origdb/testsuite/../../gdb/gdb version 2002-10-2= 9-cvs -nx >=20 >=20 > But the only difference is between gdbcvs.sum and modgdb.sum > is=20 > 5166c5166 > < FAIL: gdb.c++/annota2.exp: annotate-quit > --- > > PASS: gdb.c++/annota2.exp: annotate-quit >=20 > which, when you look into gdb.c++/annota2.exp=20 > is said to be a tests that fails sometimes, but unreproducably. >=20 > So I think that we can consider that the=20 > testsuite result is unchanged. >=20 > Can I commit the patch?