From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13307 invoked by alias); 5 Sep 2007 00:13:09 -0000 Received: (qmail 13298 invoked by uid 22791); 5 Sep 2007 00:13:09 -0000 X-Spam-Check-By: sourceware.org Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Sep 2007 00:13:04 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l850D068009809; Tue, 4 Sep 2007 17:13:00 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Tue, 4 Sep 2007 17:13:00 -0700 (PDT) Message-ID: <15809.12.7.175.2.1188951180.squirrel@webmail.sonic.net> In-Reply-To: <20070904143037.GE3579@adacore.com> References: <17390.12.7.175.2.1188425405.squirrel@webmail.sonic.net> <20070904143037.GE3579@adacore.com> Date: Wed, 05 Sep 2007 00:13:00 -0000 Subject: Re: [patch] expprint.c, check strchr return val for null. From: msnyder@sonic.net To: "Joel Brobecker" Cc: msnyder@sonic.net, gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00063.txt.bz2 >> 2007-08-29 Michael Snyder >> >> * expprint.c (print_subexp_standard): Check strchr for null. > > The extra assert looks good to me. But make sure to update Makefile.in > as well since you introduced a dependency on gdb_assert.h. OK, done and committed. > Thanks for all these patches! My pleasure. Thanks for all the review. ;-)