From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LvoDGjCqtmqBfQMAWB0awg (envelope-from ) for ; Fri, 25 Sep 2026 13:06:56 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LBg7mNZI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 578831E06B; Fri, 25 Sep 2026 13:06:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B647B1E01F for ; Fri, 25 Sep 2026 13:06:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 102D14B920F9 for ; Fri, 25 Sep 2026 17:06:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 102D14B920F9 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LBg7mNZI Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 3390B4BB593C for ; Fri, 25 Sep 2026 17:06:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3390B4BB593C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3390B4BB593C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790355990; cv=none; b=HiTNIEsCW1idnVQJ+5+99RZ5co1+IRhD3ZyigiwGFTNATF2F89RkfM7vTSbEZrZaeEwhqUFhyrQ1C8mzzJM+o/rO3LXuibV3z6XU2eNUThyMiHbBwZGkG2ALIxD4vEIgduP7nrpWlhyt9vE3EITj0E+SVvrNxUCTAJIP29De8BQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790355990; c=relaxed/simple; bh=ietBnBicoLxNKv1D+NtpEv39U+0r50mv0eC7bvVM3V0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kx+zWTGgk+mIUXT3H/l599dB7as3Jf74e0nsVZT/wtFuM6uUAeXwkbkStzho5P/A7j1m4W9S/ZN49EUiBldAZjE+pIZrt+mJk0J7ARvV2/iFWKRE9hRm/6/U13Hkraz/YOyHe3KldU5sewrsxIPEyNmwPNApg/2lI5NtzhsVAsg= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=LBg7mNZI DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3390B4BB593C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790355989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bT1h9Y7katZvHxi9hTgWYMtPQgQ92+NzirAF8hwXiS4=; b=LBg7mNZIDLBeoEs2yzuA+dYu+UJbEaxyaNGBGcCPjCqg7bDUeAqMESrzry+itSluFUMnKW RlKsim9mAW9ueNDW0XvyLcv0KHSFk9t4a22MCPNy7eoYcMMtrXbpuyeXRPbAuBdqBk8ENC tQwQ5GtfMCRpXKDC57W5oG7OGbDZ+CA= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-MGrCAxQvMEKDRQCZ_zqbdQ-1; Fri, 25 Sep 2026 13:06:28 -0400 X-MC-Unique: MGrCAxQvMEKDRQCZ_zqbdQ-1 X-Mimecast-MFC-AGG-ID: MGrCAxQvMEKDRQCZ_zqbdQ_1790355987 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-91433a91ee9so15065106d6.3 for ; Fri, 25 Sep 2026 10:06:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790355987; x=1790960787; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bT1h9Y7katZvHxi9hTgWYMtPQgQ92+NzirAF8hwXiS4=; b=EiS+zXfsOUXGWp8vTOnVKSBtRpvVlX8OzAh9EpO6qjnd8Y/DXXJfPFRYkr5kpWxWRi K7R4A8pUgSY5cnUeAD7n7LuGvbKuw016nX6rVbR2AIyGzK93i2D91G5BRsUQD/dACaCt qNxaqtwpEYjJDE8VOpcaS214BhHzYsTB2jWSuZAafDfJXemXzxsoAjG2w+LrpDYjWSZu MfaSQq+4LbHSHS/W+mzYhFQVxqTp1JrHKqOI8L5vkUTPG+cw/vcPyAXLU4AAbcvLxpU6 r4SBzGjbnQhDLGk1DwGiBsiLVAPdfrYTa73CjqhpTteEOXLUlTeIub2xnqcJes/rHkZv VgLQ== X-Forwarded-Encrypted: i=1; AKwUvBwAQ15x6LDWNqwwOJ1lIOmAxCa+yVhqXlO71kxSqKMY36PBHDipXzaM6K0PbJ9D5voP/K43Zo4EsKhOyw==@sourceware.org X-Gm-Message-State: AFuF++lzccg4AThyN8o7Y+EbOUqsw9rafEKnXA3sCbQURbBc9BFGVAc5 HQ6lleLQRQZqRCKRwAT/xfXuUxsS/4fGwMFX5hH3b4lhqbVmJb2vJwzcQxph4ZdzTmxqAMW+ifz 2Xs6oF+zGSOoofKPsJIDJAw4KsiU2ap2nsk7gyHqtfccspFqVbXtH1O/K1xMauhw= X-Gm-Gg: AYBFou3tiG421q79m6E+tKXqgkwEsKWPv9eQjXuaDF8Xr6Etx4akU9DE9NfHsM/QNfr sOLSH1CZSXCW+Ve5DBOZ+NAWr9kTKbmaaxt3RfzrUz2pkFLG3yFxIdyrasxc1StUDqsg0B8h7yc pm7XYqu+XI1hJlHF0530pxljRMOOLoWYEa23mTyo/Deo4J+OkWaUm39A91szJ2tFlGoSK9DsesY AEuTw79Nf+Hpt1q1EL740x97esXQ0Tj9glPaub88MNF3YWj8xmPTVKGlb0CDI4yu7O8aj1SqSs7 Tc+9oPMRmQ/hr8k8edZnP3W6iQF9MZXy8XuuE2QwmJ4AYh58UWeWtrykWbCxKzMmokZr5mWBr4t tPw+40J4= X-Received: by 2002:a05:6214:5f85:b0:914:3238:3007 with SMTP id 6a1803df08f44-9143238366cmr36324806d6.33.1790355987320; Fri, 25 Sep 2026 10:06:27 -0700 (PDT) X-Received: by 2002:a05:6214:5f85:b0:914:3238:3007 with SMTP id 6a1803df08f44-9143238366cmr36324126d6.33.1790355986637; Fri, 25 Sep 2026 10:06:26 -0700 (PDT) Received: from [150.1.200.157] ([172.56.108.234]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-914309a24c4sm21603166d6.6.2026.09.25.10.06.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Sep 2026 10:06:25 -0700 (PDT) Message-ID: <157b5899-a44c-4fa2-a271-95d120ed8efa@redhat.com> Date: Fri, 25 Sep 2026 10:06:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] Fix `add-symbol-file -o ... -s ...` address mapping bug To: Dragorn421 , gdb-patches@sourceware.org References: <20260924035202.4533-1-dragorn421@gmail.com> <20260924035202.4533-2-dragorn421@gmail.com> <4e94fb53-27dd-4f1f-8c46-2b6e5855b269@redhat.com> <460be511-ee67-4633-af29-d225219d1c79@gmail.com> From: Keith Seitz In-Reply-To: <460be511-ee67-4633-af29-d225219d1c79@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: VfTLOqvlCtVG_z23lSRb76-bnqd-l_q3g0fblVEm9XA_1790355987 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/25/26 12:15 AM, Dragorn421 wrote: > On 9/24/26 20:54, Keith Seitz wrote: >> Hi, >> >> Thank you for the revision. This looks good, I just note one >> tiny nit. >> >> On 9/23/26 8:51 PM, Dragorn421 wrote: >>> diff --git a/gdb/symfile.c b/gdb/symfile.c >>> index 017f7a49d8d..5691c2a46d9 100644 >>> --- a/gdb/symfile.c >>> +++ b/gdb/symfile.c >>> @@ -2163,7 +2163,7 @@ set_objfile_default_section_offset (struct >>> objfile *objf, >>>       } >>>           if (cmp == 0) >>> -    offsets[objf_sect->sectindex] = 0; >>> +    offsets[objf_sect->sectindex] = objf->section_offsets[objf_sect- >>> >sectindex]; >> >> This line is now too long. Suggest moving "= ..." to the next line as >> per our usual coding convention. No need to repost this patch. > > > Thanks for the review. > > What do you mean by "No need to repost this patch."? Should I just send > the other (test-adding) patch on its own from now on? That's what I would do, yes, but you do not have to if it is easier for you to track this. You could simply continue to post both patches. > So will a maintainer possibly take care of formatting that too-long line > after applying the patch? You would make the change locally, pushing that when a maintainer approved the whole series. My apologies for not keeping this simpler for first time contributors. Keith