From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6616 invoked by alias); 23 Oct 2002 22:57:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6609 invoked from network); 23 Oct 2002 22:57:05 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 23 Oct 2002 22:57:05 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9NMZdw10953 for ; Wed, 23 Oct 2002 18:35:39 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9NMv4f08352 for ; Wed, 23 Oct 2002 18:57:04 -0400 Received: from localhost.redhat.com (IDENT:i2Sl+GVJy6cjFZa5ljpwCp9SZKL0pvrZ@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9NMv0026577; Wed, 23 Oct 2002 18:57:01 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id F3368FF79; Wed, 23 Oct 2002 18:54:13 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15799.10389.127424.360048@localhost.redhat.com> Date: Wed, 23 Oct 2002 15:57:00 -0000 To: David Carlton Cc: Elena Zannoni , gdb-patches@sources.redhat.com, Jim Blandy Subject: Re: [patch] useless code in symtab.c In-Reply-To: References: <15799.9088.601916.908293@localhost.redhat.com> X-SW-Source: 2002-10/txt/msg00489.txt.bz2 David Carlton writes: > On Wed, 23 Oct 2002 18:32:32 -0400, Elena Zannoni said: > > > Can you also knock out the one at: > > > linespec.c:38:extern char *find_template_name_end (char *); > > That one gets used by decode_line_1. (One of these days, I'll try to > understand what that function is doing, but I'm not feeling quite that > masochistic yet.) Though I don't see any compelling reason not to > just #include "parser-defs.h" there instead of declaring that one > function specially; should I go ahead and do that? > decode_line_1, I think it will also make coffee if you ask nicely.... :-( Yes, please, and update the Makefile.in dependencies. > (Looking through ChangeLogs, I see that code in linespec.c used to be > in symtab.c; that explains why the prototype was in symtab.c.) > yes, Fernando split the two. Elena > David Carlton > carlton@math.stanford.edu