From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27815 invoked by alias); 22 Oct 2002 21:59:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27791 invoked from network); 22 Oct 2002 21:59:07 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 22 Oct 2002 21:59:07 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9MLblw02169 for ; Tue, 22 Oct 2002 17:37:47 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MLx6f22155; Tue, 22 Oct 2002 17:59:07 -0400 Received: from localhost.redhat.com (IDENT:VCNM+dafi/AjTogGQMJEP2h40/sTiCn6@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MLx5w21576; Tue, 22 Oct 2002 17:59:05 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id DA12EFF79; Tue, 22 Oct 2002 17:56:22 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15797.51590.309413.708715@localhost.redhat.com> Date: Tue, 22 Oct 2002 14:59:00 -0000 To: Andrew Cagney Cc: Michael Snyder , fnasser@redhat.com, Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: [RFA] Use vfork in shell_escape In-Reply-To: <3DB5C67E.9040700@redhat.com> References: <20021022015205.GA22323@nevyn.them.org> <3DB5BAE9.2A01D78F@redhat.com> <20021022205654.GA10208@nevyn.them.org> <3DB5BC72.3DE58BD@redhat.com> <3DB5C67E.9040700@redhat.com> X-SW-Source: 2002-10/txt/msg00432.txt.bz2 Andrew Cagney writes: > > Daniel Jacobowitz wrote: > > > >> > >> On Tue, Oct 22, 2002 at 01:54:01PM -0700, Michael Snyder wrote: > > > >> > Daniel Jacobowitz wrote: > > > >> > > > >> > > This patch is pretty obvious. I couldn't figure out why my machine was > >> > > running out of memory; forking GDB to run an 'ls' during the maint.exp tests > >> > > can be a bit heavy, since it may have all of glibc's debug info loaded. > >> > > This patch seems logical to me... OK to commit? > > > >> > > >> > Not as is. There's some auto-confery involved, since many systems > >> > (some systems?) don't have vfork. Grep for vfork in fork-child.c. > > > >> > >> Not as much as there used to be. But you're right, I goofed. OK with > >> the addition of '#include "gdb_vfork.h"', which is all fork-child.c > >> uses now? > > > > > > For all I know, that's OK -- but I don't know. > > I'll step back now, and wait for someone who does. > > Yep, from the ARI: > > HAVE VFORK #ifdef HAVE_VFORK is redundant. Include "gdb_vfork.h" and > call vfork() unconditionally. > What about hpux? [go look....] Ah, right, we "fixed" hpux by enforcing -Dvfork=fork Elena > Fernando - CLI? > > Andrew >