Re: RFA: change for gdb/mi 495

Elena Zannoni
2002-10-22T16:00:54Z

J. Johnston writes:
> The following is a patch for gdb/mi 495. The PR requests changing ui_out_field_core_addr
> to use core_addr_to_string().
>
> Ok to commit?
>

I think it is ok. No unexpected changes in the output, I take it.

Elena

> -- Jeff J.
>
> gdb/ChangeLog:
>
> 2002-10-21 Jeff Johnston <jjohnstn@redhat.com>
>
> * ui-out.c (ui_out_field_core_addr): Change to call core_addr_to_string().Index: ui-out.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/ui-out.c,v
> retrieving revision 1.24
> diff -u -r1.24 ui-out.c
> --- ui-out.c 3 Oct 2002 22:34:58 -0000 1.24
> +++ ui-out.c 22 Oct 2002 00:02:17 -0000
> @@ -507,16 +507,7 @@
> const char *fldname,
> CORE_ADDR address)
> {
> - char addstr[20];
> -
> - /* FIXME: cagney/2002-05-03: Need local_address_string() function
> - that returns the language localized string formatted to a width
> - based on TARGET_ADDR_BIT. */
> - /* print_address_numeric (address, 1, local_stream); */
> - if (TARGET_ADDR_BIT <= 32)
> - strcpy (addstr, local_hex_string_custom (address, "08l"));
> - else
> - strcpy (addstr, local_hex_string_custom (address, "016l"));
> + const char *addstr = core_addr_to_string (address);
>
> ui_out_field_string (uiout, fldname, addstr);
> }