From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17661 invoked by alias); 22 Oct 2002 16:49:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17647 invoked from network); 22 Oct 2002 16:49:32 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 22 Oct 2002 16:49:32 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9MGSEw07905 for ; Tue, 22 Oct 2002 12:28:14 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MGnWf25876; Tue, 22 Oct 2002 12:49:32 -0400 Received: from localhost.redhat.com (IDENT:Gt8ZPeJHiw5eYkckFFs3pHRP+J8edqnq@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MGnVw31340; Tue, 22 Oct 2002 12:49:31 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 3C9CCFF79; Tue, 22 Oct 2002 12:46:46 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15797.33014.49965.677460@localhost.redhat.com> Date: Tue, 22 Oct 2002 09:49:00 -0000 To: Andrew Cagney Cc: Elena Zannoni , "J. Johnston" , gdb-patches@sources.redhat.com Subject: Re: RFA: change for gdb/mi 495 In-Reply-To: <3DB57D67.1000304@redhat.com> References: <3DB496BD.E55975B1@redhat.com> <15797.30097.60141.274031@localhost.redhat.com> <3DB57D67.1000304@redhat.com> X-SW-Source: 2002-10/txt/msg00409.txt.bz2 Andrew Cagney writes: > > J. Johnston writes: > > > The following is a patch for gdb/mi 495. The PR requests changing ui_out_field_core_addr > > > to use core_addr_to_string(). > > > > > > Ok to commit? > > > > > > > I think it is ok. No unexpected changes in the output, I take it. > > Hmm, I'd like to think about this for a bit. Check exactly where it is > called. > In various places, but the main/easiest to check is the address at the beginning of a disassembly line. Other calls are in the frame displaying code. Elena > Andrew >