From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18609 invoked by alias); 22 Oct 2002 15:04:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18598 invoked from network); 22 Oct 2002 15:04:45 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 22 Oct 2002 15:04:45 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9MEhRw12882 for ; Tue, 22 Oct 2002 10:43:27 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MF4jf28231; Tue, 22 Oct 2002 11:04:45 -0400 Received: from localhost.redhat.com (IDENT:3sMSwKhvp2J6u/S1Izyu/O5C5ElstLh0@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9MF4hw24002; Tue, 22 Oct 2002 11:04:43 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id CEB39FF79; Tue, 22 Oct 2002 11:02:00 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15797.26727.910788.608785@localhost.redhat.com> Date: Tue, 22 Oct 2002 08:04:00 -0000 To: Adam Fedor Cc: Elena Zannoni , Jim Blandy , Klee Dienes , Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Redefine skip_quoted In-Reply-To: <3DB09113.9070205@doc.com> References: <95706CBA-DFBC-11D6-A1B6-00039396EEB8@apple.com> <3DAF2C71.6030908@doc.com> <15792.33251.884402.152637@localhost.redhat.com> <3DB09113.9070205@doc.com> X-SW-Source: 2002-10/txt/msg00397.txt.bz2 Adam Fedor writes: > Elena Zannoni wrote: > > Adam Fedor writes: > > > Jim Blandy wrote: > > > > Klee Dienes writes: > > > > > > > >>In the Apple code, we use skip_quoted to allow for the possibility of > > > >>spaces in Objective-C function names. > > > >> > > > >>I'm actually coming to think that allowing people to break on unquoted > > > >>Objective-C methods was a mistake: it's caused us no end of trouble > > > >>trying to shoehorn decode_line_1() into handling every possible > > > >>edge-case. I'm not sure how practical it is for us to remove it at > > > >>this point, though --- we'd have to do some research among our > > > >>Objective-C developers to find out how important a feature it is to > > > >>them, I think. > > > > > > > > > > > > So, the original patch posted is preparation for a behavior which you > > > > now suspect was a mistake, and which has caused you no end of trouble? > > > > (Or do I have the sense of what you were saying reversed?) You can > > > > forgive me if hearing that makes me a bit hesitant to approve the > > > > patch, right? :) > > > > > > > > > > Well, really the use of skip_quoted for ObjC (in a patch that I haven't > > > submitted yet), really has more to do with handling the canonical form > > > of an Objective-C method symbol (e.g. -[MyObject myMethod:arg2:]) that > > > comes from objc-lang.c. Most of the breakpoint cases that a user would > > > enter are handled elsewhere (in a patch that I also haven't submitted). > > > > > > > I have to agree with Jim here, I think we should wait on the parts you > > haven't submitted before deciding on this one. Could you just have > > added the chars you need to the gdb_completer_word_break_characters > > variable? > > > > No. It involves removing characters. Another option would be to define a > new function, say skip_objc_quoted, just for objc which would be similar > to skip_quoted. How about that? Hmmm,... I think the best approach would be to continue what you started, then, and define another set (sonething like gdb_objc_completer_word_break_characters), and have the get_... function return the correct one based on the current language. Is that what you were going to do? Elena > > > -- > Adam Fedor, Digital Optics Corp. | I'm glad I hate spinach, because > http://www.doc.com | if I didn't, I'd eat it, and you > | know how I hate the stuff.