From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13384 invoked by alias); 21 Oct 2002 12:45:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13374 invoked from network); 21 Oct 2002 12:45:10 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 21 Oct 2002 12:45:10 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9LCNvw04978 for ; Mon, 21 Oct 2002 08:23:57 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9LCj9f27536 for ; Mon, 21 Oct 2002 08:45:09 -0400 Received: from localhost.redhat.com (IDENT:YvDJjum24+kwsB+elUjulPagFgYAybGQ@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9LCj4T12719; Mon, 21 Oct 2002 08:45:08 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 89110FF79; Mon, 21 Oct 2002 08:42:23 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15795.63023.405869.767752@localhost.redhat.com> Date: Mon, 21 Oct 2002 05:45:00 -0000 To: Michal Ludvig Cc: Elena Zannoni , GDB Patches Subject: Re: [RFA] sighandler backtrace on x86-64 In-Reply-To: <3D8ADBF0.9040808@suse.cz> References: <3D8877EE.4090203@suse.cz> <15753.62506.951316.119928@localhost.redhat.com> <3D8ADBF0.9040808@suse.cz> X-SW-Source: 2002-10/txt/msg00333.txt.bz2 Michal Ludvig writes: > Elena Zannoni wrote: > > Do you need to make the whole structure accessible? would it be enough > > for your purposes to just add > > struct context; > > struct context_reg; > > to the .h file? > > Hmm, I don't think so. I'm afraid I'll have to artifically create the > content of context_reg for the sighandler caller frame. > If you need to access the fields of the structure later on, then it's fine. > > I don't see any uses of the structures and functions you are > > exporting. > > Could you postpone these changes until they are actually used? > > Sure I can. Anyway having all structures in .h isn't a bad habit, is it? > No, having the whole structure is fine, if it is used. If you just need it for passing paramters around, w/o accessing the internal fields, then it's better not exporting the whole struct, to keep the interface a bit tighter. > > > +struct context *context_alloc (); > > > +void context_cpy (struct context *dst, struct context *src); > > > +struct frame_state *frame_state_alloc (); > > > > 'extern' keyword? > > It is the default for function declarations, and AFAIK is never used for > them in gdb's headers. > Hmmm, it is customary to use it. > Can I commit without the struct context movement? > Yes, but I have noticed a few non-gnu style problems in x86-64.c: > + if(fp) > + fp = read_memory_integer (addr + LINUX_SIGCONTEXT_FP_OFFSET, 8)+8; > + if(fi->next && fi->next->signal_handler_caller) Could you fix them before committing? Thanks Elena > Michal Ludvig > -- > * SuSE CR, s.r.o * mludvig@suse.cz > * +420 2 9654 5373 * http://www.suse.cz