Re: [RFA] Ooopsie in mi/mi-main.c

[Elena Zannoni <ezannoni@redhat.com>]

Joel Brobecker writes:
 > The following change broke the build:
 > 
 >         * mi-main.c (mi_cmd_exec_return): Don't use
 >         return_command_wrapper, use return_command instead.
 >         (mi_cmd_exec_interrupt): Don't use
 >         interrupt_target_command_wrapper, use interrupt_target_command
 >         instead.
 > 
 > I am quite busy at the moment, so did not spend too much time investigating
 > how this should be fixed. I suggest the following fix.
 > 
 > 2002-10-02  Joel Brobecker  <brobecker@gnat.com>
 > 
 >         * infcmd.c (interrupt_target_command): Make non-static, as it
 >         is now needed by mi-main.c.
 >         * stack.c (return_command): Likewise.
 > 
 > Ok to apply?
 > 

Ouch, sorry. I forgot to check in a part of the patch. I am doing it now.

Elena


 > Thanks,
 > -- 
 > Joel
 > Index: infcmd.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/infcmd.c,v
 > retrieving revision 1.56
 > diff -c -3 -p -r1.56 infcmd.c
 > *** infcmd.c	25 Sep 2002 20:30:37 -0000	1.56
 > --- infcmd.c	3 Oct 2002 01:55:21 -0000
 > *************** void all_registers_info (char *, int);
 > *** 50,55 ****
 > --- 50,57 ----
 >   
 >   void registers_info (char *, int);
 >   
 > + void interrupt_target_command (char *args, int from_tty);
 > + 
 >   /* Local functions: */
 >   
 >   void continue_command (char *, int);
 > *************** static void float_info (char *, int);
 > *** 72,79 ****
 >   
 >   static void detach_command (char *, int);
 >   
 > - static void interrupt_target_command (char *args, int from_tty);
 > - 
 >   static void unset_environment_command (char *, int);
 >   
 >   static void set_environment_command (char *, int);
 > --- 74,79 ----
 > *************** interrupt_target_command_wrapper (char *
 > *** 1898,1904 ****
 >     interrupt_target_command (args, from_tty);
 >   }
 >   
 > ! static void
 >   interrupt_target_command (char *args, int from_tty)
 >   {
 >     if (event_loop_p && target_can_async_p ())
 > --- 1898,1904 ----
 >     interrupt_target_command (args, from_tty);
 >   }
 >   
 > ! void
 >   interrupt_target_command (char *args, int from_tty)
 >   {
 >     if (event_loop_p && target_can_async_p ())
 > Index: stack.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/stack.c,v
 > retrieving revision 1.44
 > diff -c -3 -p -r1.44 stack.c
 > *** stack.c	22 Sep 2002 22:18:41 -0000	1.44
 > --- stack.c	3 Oct 2002 01:55:21 -0000
 > *************** void args_info (char *, int);
 > *** 46,59 ****
 >   
 >   void locals_info (char *, int);
 >   
 >   void (*selected_frame_level_changed_hook) (int);
 >   
 >   void _initialize_stack (void);
 >   
 >   /* Prototypes for local functions. */
 >   
 > - static void return_command (char *, int);
 > - 
 >   static void down_command (char *, int);
 >   
 >   static void down_silently_base (char *);
 > --- 46,59 ----
 >   
 >   void locals_info (char *, int);
 >   
 > + void return_command (char *, int);
 > + 
 >   void (*selected_frame_level_changed_hook) (int);
 >   
 >   void _initialize_stack (void);
 >   
 >   /* Prototypes for local functions. */
 >   
 >   static void down_command (char *, int);
 >   
 >   static void down_silently_base (char *);
 > *************** return_command_wrapper (char *retval_exp
 > *** 1760,1766 ****
 >     return_command (retval_exp, from_tty);
 >   }
 >   
 > ! static void
 >   return_command (char *retval_exp, int from_tty)
 >   {
 >     struct symbol *thisfun;
 > --- 1760,1766 ----
 >     return_command (retval_exp, from_tty);
 >   }
 >   
 > ! void
 >   return_command (char *retval_exp, int from_tty)
 >   {
 >     struct symbol *thisfun;