From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21507 invoked by alias); 3 Oct 2002 01:49:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21500 invoked from network); 3 Oct 2002 01:49:04 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 3 Oct 2002 01:49:04 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g931U8024695 for ; Wed, 2 Oct 2002 21:30:08 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g931n3f04520 for ; Wed, 2 Oct 2002 21:49:03 -0400 Received: from localhost.redhat.com (IDENT:root@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g931n0914229; Wed, 2 Oct 2002 21:49:01 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 818A7FF79; Wed, 2 Oct 2002 21:46:37 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15771.41341.316069.924362@localhost.redhat.com> Date: Wed, 02 Oct 2002 18:49:00 -0000 To: Jim Blandy Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFC] TLS support part 1 In-Reply-To: References: <15770.25139.262675.365054@localhost.redhat.com> X-SW-Source: 2002-10/txt/msg00096.txt.bz2 Jim Blandy writes: > > Elena Zannoni writes: > > @@ -611,8 +611,16 @@ enum address_class > > target-specific method. This is used only by hppa. */ > > > > LOC_HP_THREAD_LOCAL_STATIC, > > + > > + /* Value is at a thread-specific location calculated by a > > + target-specific method. SYMBOL_OBJFILE gives the object file > > + in which the symbol is defined; the symbol's value is the > > + o > > + /* Value is at a thread-specific location calculated by a > > + target-specific method. SYMBOL_OBJFILE gives the object file > > + in which the symbol is defined; the symbol's value is the > > + offset into that objfile's thread-local storage for the current > > + thread. */ > > + > > LOC_THREAD_LOCAL_STATIC, > > > > /* The variable does not actually exist in the program. > > Busted patch? > Yeah, I copied the diff into this email....silly fingers. > > @@ -684,6 +692,12 @@ struct symbol > > { > > /* Used by LOC_BASEREG and LOC_BASEREG_ARG. */ > > short basereg; > > + > > + /* The objfile in which this symbol is defined. To find a > > + thread-local variable (e.g., a variable declared with the > > + `__thread' storage class), we may need to know which object > > + file it's in. */ > > + struct objfile *objfile; > > } > > aux_value; > > I think probably every element of aux_value should have a comment > indicating which sorts of address classes it's valid for; this comment > mentions thread-local variables, but it should probably be more > explicit about the fact that objfile is valid only for > LOC_THREAD_LOCAL_STATIC. > Yes, that would be a good idea. > (I think the comment in your patch here comes directly from my early > patch, so I'm complaining about my own writing here. Oh well.) yes :-) split personality disorder? Elena