From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28624 invoked by alias); 30 Sep 2002 21:13:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28617 invoked from network); 30 Sep 2002 21:13:15 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 30 Sep 2002 21:13:15 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g8UKsdi13091 for ; Mon, 30 Sep 2002 16:54:39 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g8ULDEf19731; Mon, 30 Sep 2002 17:13:14 -0400 Received: from localhost.redhat.com (IDENT:root@tooth.toronto.redhat.com [172.16.14.29]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g8ULBJE09364; Mon, 30 Sep 2002 17:11:20 -0400 Received: by localhost.redhat.com (Postfix, from userid 469) id 312E8FF7A; Mon, 30 Sep 2002 17:06:59 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15768.48370.999618.771334@localhost.redhat.com> Date: Mon, 30 Sep 2002 14:13:00 -0000 To: jjohnstn@redhat.com, Keith Seitz Cc: "J. Johnston" , gdb-patches@sources.redhat.com Subject: Re: Patch for gdb/mi problem 672 In-Reply-To: References: <3D94DB49.BF3C3520@redhat.com> X-SW-Source: 2002-09/txt/msg00778.txt.bz2 Keith Seitz writes: > Hi, > > Although I know that varobj shouldn't longjmp in case of errors, I don't > think that this is going to be a safe assumption. I would recommend that > you refrain from using ui_out_*_begin and ui_out_*_end, and instead use > make_cleanup_ui_out_*_begin_end and do_cleanups, which will make sure that > the UIOUT builder is properly reset in case of errors. (See, for example, > the cleanup that I did in mi_cmd_data_list_registers.) Yes, right. I keep forgetting about this myself. Jeff, the cleanups are done in case of error (i.e. longjump) out of this function. If not, the nesting and depth of the lists would be messed up for the next command that uses them. Other than such change, approved. When you commit, repost the patch that actually went in. For the testsuite: mi0 is no more. These modified tests should go in as mi2-var-child.exp, etc, leaving the mi-var... unchanged. Is this the intent? Andrew? thanks Elena > > On Fri, 27 Sep 2002, J. Johnston wrote: > > > @@ -419,10 +419,10 @@ > > if ((*name == '*') && (*(name + 1) == '\0')) > > { > > nv = varobj_list (&rootlist); > > - ui_out_tuple_begin (uiout, "changelist"); > > + ui_out_list_begin (uiout, "changelist"); > > if (nv <= 0) > > { > > - ui_out_tuple_end (uiout); > > + ui_out_list_end (uiout); > > return MI_CMD_DONE; > > } > > cr = rootlist; > > [Andrew has already addressed the MI0 thing...] > > Other than that, I would recommend that it be approved (for whatever > that's worth). > > Keith >