From: Elena Zannoni <ezannoni@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: Elena Zannoni <ezannoni@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFC] Interpreters (~final) (fwd)
Date: Mon, 30 Sep 2002 11:35:00 -0000 [thread overview]
Message-ID: <15768.35078.659373.108910@localhost.redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0209231251060.10013-200000@lindt.uglyboxes.com>
I am looking more at the branch than at the patch. I am trying to come
up with another way of breaking this down. If I am lucky.
A couple of little things I noticed. More in a bit.
The error messages in interps.c print strings with mi_ in them, like:
+ error
+ ("interpreter-exec: mi_interpreter_execute: error in command: \"%s\".",
+ prules[i]);
The use of wrapper.[ch] is discouraged. Put the necessary safe
functions near where they are used (so we wack 2 files from the list
of stuff to merge). Look at corefile.c:safe_read_memory_integer, for
instance.
Who uses gdb_delete_interpreter? If it is there "just in case" add a
comment that says so.
I bet more changes are coming down the pipe, but could we tighten the
interfaces a bit. I think some more functions could be made static and
removed from .h files.
Elena
next prev parent reply other threads:[~2002-09-30 18:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-06 8:40 Keith Seitz
2002-09-22 15:40 ` Elena Zannoni
2002-09-23 11:57 ` Keith Seitz
2002-09-23 12:44 ` Keith Seitz
2002-09-30 11:35 ` Elena Zannoni [this message]
2002-09-30 15:58 ` Elena Zannoni
[not found] <1030485672.17451.ezmlm@sources.redhat.com>
2002-08-27 15:21 ` Jim Ingham
-- strict thread matches above, loose matches on Subject: below --
2002-08-27 9:26 Keith Seitz
2002-08-27 15:01 ` Michael Snyder
2002-08-27 15:19 ` Keith Seitz
2002-08-28 7:14 ` Eli Zaretskii
2002-08-28 8:37 ` Keith Seitz
2002-08-28 9:03 ` Eli Zaretskii
2002-08-28 13:33 ` Michael Snyder
2002-08-28 17:13 ` Andrew Cagney
2002-08-28 22:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15768.35078.659373.108910@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox