From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17716 invoked by alias); 30 Sep 2002 16:44:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17708 invoked from network); 30 Sep 2002 16:44:20 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 30 Sep 2002 16:44:20 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id 36319FF79; Mon, 30 Sep 2002 12:41:17 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15768.32428.867105.772361@localhost.redhat.com> Date: Mon, 30 Sep 2002 09:44:00 -0000 To: Fernando Nasser Cc: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: RFC/RFA: Move new disassembler to libgdb proper In-Reply-To: <3D98695A.5020406@redhat.com> References: <3D9394BA.2040605@redhat.com> <3D93BF54.30809@redhat.com> <3D98695A.5020406@redhat.com> X-SW-Source: 2002-09/txt/msg00761.txt.bz2 Just a thought. How about the TUI. Do we care about unifying its disassemble with this one as well? Elena Fernando Nasser writes: > Andrew Cagney wrote: > > Two tweeks: > > > >> + /* Disassemble support for GDB. > >> + Copyright 2000, 2001, 2002 Free Software Foundation, Inc. > >> + Contributed by Cygnus Solutions (a Red Hat company). > > > > > > The (C) should just be 2002 and ``Red Hat, Inc.''. > > > > OK. I was not sure, as the code is older than that. But I guess the copyright > goes by the file, not the code... > > > >> + This file is part of GDB. > >> + + This program is free software; you can redistribute it and/or > >> modify > >> + it under the terms of the GNU General Public License as published by > >> + the Free Software Foundation; either version 2 of the License, or > >> + (at your option) any later version. > >> + + This program is distributed in the hope that it will be useful, > >> + but WITHOUT ANY WARRANTY; without even the implied warranty of > >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > >> + GNU General Public License for more details. > >> + + You should have received a copy of the GNU General Public License > >> + along with this program; if not, write to the Free Software > >> + Foundation, Inc., 59 Temple Place - Suite 330, > >> + Boston, MA 02111-1307, USA. */ > >> + + extern void gdb_disassembly (char *file_string, > >> + int line_num, > >> + int mixed_source_and_assembly, > >> + int how_many, CORE_ADDR low, CORE_ADDR high); > > > > > > It needs #ifdef DISASM_H et.al. > > Yes, how could I forget! > > > It should take an explicit ui_out parameter. > > > > Good point. Of all people I should have remembered that one ;-) > > > As for the rest vis: > > > >> ! static int > >> ! gdb_dis_asm_read_memory (bfd_vma memaddr, bfd_byte * myaddr, > >> ! unsigned int len, disassemble_info * info) > >> ! { > >> ! extern struct target_ops exec_ops; > > > > > > I guess we all get to grit our teeth because we know you're just moving > > around existing code :-) > > > > It seems that it may need some clean-up. But you are right, I am just moving > code and I like to do the least possible changes on that pass. > > One of us should take a look and see if there is something else. It will be > easier to maintain it as it becomes the only disassembler code instead of one of > many. > > > Thanks for looking at this. I will make the changes and check it in. > > Regards, > Fernando > > > -- > Fernando Nasser > Red Hat - Toronto E-Mail: fnasser@redhat.com > 2323 Yonge Street, Suite #300 > Toronto, Ontario M4P 2C9