From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OVbrG9Zz5V+FTAAAWB0awg (envelope-from ) for ; Fri, 25 Dec 2020 00:08:38 -0500 Received: by simark.ca (Postfix, from userid 112) id 5D42A1F0AA; Fri, 25 Dec 2020 00:08:38 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 01F1D1E590 for ; Fri, 25 Dec 2020 00:08:38 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4033D3858026; Fri, 25 Dec 2020 05:08:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4033D3858026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608872917; bh=I3Vjs/BdSKlR6td0++K6y2oN9Mc8D9tb5aZXOllkiYE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MrKs/V0wOoC542AQETN/SQgfrOWzQ8Q4BuWkj7UOzJAH1H9Q5ubUbyd39oC9CGuY4 sWhtnMhkt21GUr5SBL2fh9euWxgyo3hxjJTCk0CDZPuIsWNfxHcfETUaLJL9EANkgX jf/Fj8MpjI2kUP743gfxMn5+NNYzgprfDQZnpAwU= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 4FE923858026 for ; Fri, 25 Dec 2020 05:08:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4FE923858026 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BP58Spw021911 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 25 Dec 2020 00:08:33 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BP58Spw021911 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D01DB1E590; Fri, 25 Dec 2020 00:08:28 -0500 (EST) Subject: Re: [PATCH v3 01/24] New target methods for memory tagging support To: Luis Machado , gdb-patches@sourceware.org References: <20201109170435.15766-1-luis.machado@linaro.org> <20201109170435.15766-2-luis.machado@linaro.org> Message-ID: <15766565-c8c1-7836-8b04-0da7955a2136@polymtl.ca> Date: Fri, 25 Dec 2020 00:08:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201109170435.15766-2-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 25 Dec 2020 05:08:29 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: david.spickett@linaro.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > + /* Return the allocated memory tags of type TYPE associated with > + [ADDRESS, ADDRESS + LEN) in TAGS. > + > + LEN is the number of bytes in the memory range. TAGS is a vector of > + bytes containing the tags found in the above memory range. > + > + It is up to the architecture/target to interpret the bytes in the TAGS > + vector and read the tags appropriately. */ > + virtual int fetch_memtags (CORE_ADDR address, size_t len, > + gdb::byte_vector &tags, int type) > + TARGET_DEFAULT_IGNORE (); > + > + /* Write the allocation tags of type TYPE contained in TAGS to the memory > + range [ADDRESS, ADDRESS + LEN). > + > + LEN is the number of bytes in the memory range. TAGS is a vector of > + bytes containing the tags to be stored to the memory range. > + > + It is up to the architecture/target to interpret the bytes in the TAGS > + vector and store them appropriately. */ > + virtual int store_memtags (CORE_ADDR address, size_t len, > + const gdb::byte_vector &tags, int type) Some more feedback: make the return values bool, if they are bool, and document the meaning in the comment. Simon