From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69791 invoked by alias); 13 Mar 2017 15:12:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69650 invoked by uid 89); 13 Mar 2017 15:12:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f181.google.com Received: from mail-wr0-f181.google.com (HELO mail-wr0-f181.google.com) (209.85.128.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Mar 2017 15:12:45 +0000 Received: by mail-wr0-f181.google.com with SMTP id l37so105806137wrc.1 for ; Mon, 13 Mar 2017 08:12:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=vVQKvyv2DpAqM6XauPDrN7GmqadAL7unQGmmQgA/+z8=; b=WH2CGwHpjeNUi3Od8opRe4c6HHVt7YCb4nMl8sjRcbhzCxC5DX1BtJEg6jpJsi5Z6b fr6ebYkMkCuqYMqA6atid30h0m1VUNTBxx0H0+yk2joE27ZbauyQUU+KM04XbwWf7Kzy f5M7SBc1UBPWZiPiV2/Hg7jgE/Y5ti5Hk/Ng9lHz5sWeXyZIKo/24LQEBDLBarpg8Jm7 B+leRHzu/9VWLLEWXS+tzJcaBs6dIMgGxphZmVaOx1Y3nIwGjiSQ8p4AqjiTEiBa1Ejn 2DfxEIvoVruZpaSNraONVGHBjcW3jckahxMJgwa1qRdOQVzdjb2cLH/pmfHqjbwBa39E QdFA== X-Gm-Message-State: AMke39kc8ji4BZvSF5PttfzflRK88YXaVcxgIhTaCaPi49QduTIK+y7Zot4PtXxj9m60WOWp X-Received: by 10.223.137.2 with SMTP id s2mr31152293wrs.20.1489417964258; Mon, 13 Mar 2017 08:12:44 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id f67sm11746308wmd.0.2017.03.13.08.12.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Mar 2017 08:12:43 -0700 (PDT) Subject: Re: [PATCH v3 6/6] Implement proper "startup-with-shell" support on gdbserver To: Sergio Durigan Junior References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170208032257.15443-1-sergiodj@redhat.com> <20170208032257.15443-7-sergiodj@redhat.com> <87zigwerc0.fsf@redhat.com> Cc: GDB Patches , Luis Machado From: Pedro Alves Message-ID: <1575a0b5-b58e-60ab-49a9-e235f12f1e56@redhat.com> Date: Mon, 13 Mar 2017 15:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87zigwerc0.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00189.txt.bz2 On 03/07/2017 08:59 PM, Sergio Durigan Junior wrote: >> Note, you'll need NEWS entries for the new remote protocol packets too. > > I've added a NEWS entry for QStartupWithShell under the "New remote > packets" section. Do you want me to add another entry somewhere else? > Not offhand. I'll take a look at v4. >> Can you explain the rationale for doing this here? What about: >> >> (gdb) target extended-remote .... >> (gdb) set startup-with-shell off >> (gdb) run >> >> ? > > Hm, I guess it just seemed like a good place to initialize the packet. > But you're right, this won't work if the user sets the > startup-with-shell parameter *after* connecting to the target. So I'll > move this code to the extended_remote_create_inferior function, if > that's alright. Yes, that sounds like the right place. This is quite similar to disabling address space randomization, and we do that in extended_remote_create_inferior too. Thanks, Pedro Alves