Re: [RFA] sighandler backtrace on x86-64

Michal Ludvig
2002-09-20T08:27:31Z

Elena Zannoni wrote:
> Do you need to make the whole structure accessible? would it be enough
> for your purposes to just add
> struct context;
> struct context_reg;
> to the .h file?

Hmm, I don't think so. I'm afraid I'll have to artifically create the
content of context_reg for the sighandler caller frame.

> I don't see any uses of the structures and functions you are
> exporting.
> Could you postpone these changes until they are actually used?

Sure I can. Anyway having all structures in .h isn't a bad habit, is it?

> > +struct context *context_alloc ();
> > +void context_cpy (struct context *dst, struct context *src);
> > +struct frame_state *frame_state_alloc ();
>
> 'extern' keyword?

It is the default for function declarations, and AFAIK is never used for
them in gdb's headers.

Can I commit without the struct context movement?

Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* +420 2 9654 5373 * http://www.suse.cz