From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23439 invoked by alias); 24 Nov 2016 19:15:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23430 invoked by uid 89); 24 Nov 2016 19:15:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=hmmm, VEC, Hx-languages-length:698, HX-Greylist:EST X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Nov 2016 19:15:19 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 46A2B10A9E0; Thu, 24 Nov 2016 14:15:17 -0500 (EST) From: John Baldwin To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Fix mismatched struct vs class tags. Date: Thu, 24 Nov 2016 19:15:00 -0000 Message-ID: <1573845.CKxfuZpZBq@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: <1f8967dd-3a56-8c1e-6ad2-b47b101e90ec@redhat.com> References: <20161123200652.89209-1-jhb@FreeBSD.org> <5282476.671uSJnE6M@ralph.baldwin.cx> <1f8967dd-3a56-8c1e-6ad2-b47b101e90ec@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00784.txt.bz2 On Thursday, November 24, 2016 06:50:30 PM Pedro Alves wrote: > On 11/24/2016 05:45 PM, John Baldwin wrote: > > > Ok. At the moment we don't have a clang-specific warning set, but if we > > add one we can add this to that. > > We likely don't need one. Our infrustruture checks whether a > warning works before enabling it. See gdb/warning.m4. Hmmm. The only odd case I can think of is -Wunused-function. Right now clang triggers warnings when VEC() is used, so ideally -Wunused-function would only be present for GCC and not for clang. I can look at adding other -Wno-foo warnings for clang things we wish to ignore however. -- John Baldwin