From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-18386-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 17722 invoked by alias); 4 Sep 2002 21:47:25 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 17715 invoked from network); 4 Sep 2002 21:47:24 -0000
Received: from unknown (HELO localhost.redhat.com) (66.30.197.194)
  by sources.redhat.com with SMTP; 4 Sep 2002 21:47:24 -0000
Received: by localhost.redhat.com (Postfix, from userid 469)
	id 8A9C5106CC; Wed,  4 Sep 2002 17:45:30 -0400 (EDT)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15734.32505.573421.235366@localhost.redhat.com>
Date: Wed, 04 Sep 2002 14:47:00 -0000
To: Grace Sainsbury <graces@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: insight rename patch
In-Reply-To: <20020904173728.A11943@tomago.toronto.redhat.com>
References: <20020904173728.A11943@tomago.toronto.redhat.com>
X-SW-Source: 2002-09/txt/msg00060.txt.bz2

Grace Sainsbury writes:
 > Here is the patch modified as suggested.
 > 
 > ok to commit?

A few comments below on the main/top files.

 > 
 > grace
 > 
 > 2002-09-04  Grace Sainsbury  <graces@redhat.com>
 > 
 > 	    * top.c: Set use_windows to default to zero.
 > 	    * main.c: Move main function to insight.c, gdb.c
 > 	    (gdb_main): New function.
 > 	    * main.h: New file.
 > 	    * insight.c: New File.
 > 	    * gdb.c: New File.
 > 	    * Makefile.in: Add rules for gdb.o, insight.o and
 > 	    * insight. Change
 > 	    gdbtk-install, gdbtk-uninstall, and GDBTK_ALL to reflect this.
 > Index: main.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/main.c,v
 > retrieving revision 1.18
 > diff -u -r1.18 main.c
 > --- main.c	25 Jun 2002 05:35:16 -0000	1.18
 > +++ main.c	4 Sep 2002 21:36:21 -0000
 > @@ -112,6 +112,7 @@
 >    {
 >      int argc;
 >      char **argv;
 > +    int use_windows;
 >    };
 >  


There should only be one of struct captured_main_args, in main.h.


 >  static int
 > @@ -735,11 +736,9 @@
 >  }
 >  
 >  int
 > -main (int argc, char **argv)
 > +gdb_main (struct captured_main_args *args)
 >  {
 > -  struct captured_main_args args;
 > -  args.argc = argc;
 > -  args.argv = argv;
 > +  use_windows = args->use_windows;
 >    catch_errors (captured_main, &args, "", RETURN_MASK_ALL);
 >    return 0;
 >  }
 > Index: main.h
 > ===================================================================
 > RCS file: main.h
 > diff -N main.h
 > --- /dev/null	1 Jan 1970 00:00:00 -0000
 > +++ main.h	4 Sep 2002 21:36:21 -0000
 > @@ -0,0 +1,13 @@
 > +#ifndef MAIN_H
 > +#define MAIN_H
 > +
 > +struct captured_main_args
 > +{
 > +    int argc;
 > +    char **argv;
 > +    int use_windows;
 > +};
 > +
 > +int gdb_main (struct captured_main_args *);

Should have the 'extern' keyword here.

 > +
 > +#endif
 > Index: top.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/top.c,v
 > retrieving revision 1.66
 > diff -u -r1.66 top.c
 > --- top.c	18 Aug 2002 12:39:03 -0000	1.66
 > +++ top.c	4 Sep 2002 21:36:22 -0000
 > @@ -82,7 +82,7 @@
 >  /* If nonzero, and GDB has been configured to be able to use windows,
 >     attempt to open them upon startup.  */
 >  
 > -int use_windows = 1;
 > +int use_windows = 0;
 >  
 >  extern char lang_frame_mismatch_warn[];		/* language.c */
 >  

OK

Elena