From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32259 invoked by alias); 29 Aug 2002 15:03:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32248 invoked from network); 29 Aug 2002 15:03:42 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 29 Aug 2002 15:03:42 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id D49C7108F6; Thu, 29 Aug 2002 11:01:47 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15726.14171.621119.721148@localhost.redhat.com> Date: Thu, 29 Aug 2002 08:07:00 -0000 To: Keith Seitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] stack.c: Always set current_source_{symtab,line} In-Reply-To: References: X-SW-Source: 2002-08/txt/msg00975.txt.bz2 Keith Seitz writes: > Hi, > > Another MI fallout. This has changed a few times in the past few months, > but I believe that this is how it should be for anything that uses the > CLI/command interpreter. > > Without this, an -interpreter-exec call in MI will get "lost". (Use MI to > stop at breakpoint, step a few times, use console interp to "break" -- > breakpoint would be set someplace other than current location.) > Seems an ok patch, but do you have an example command sequence before/after that shows where things go wrong? I am having a bit of a hard time visualizing the interaction. Elena > I've run this through the testsuite, and it introduces no new failures. > (And of course, it still works with Insight.) > > Keith > > ChangeLog > 2002-08-14 Keith Seitz > > * stack.c (print_frame_info_base): Always set current_source_symtab > and current_source_line. > > Patch > Index: stack.c > =================================================================== > RCS file: /cvs/src/src/gdb/stack.c,v > retrieving revision 1.40 > diff -p -r1.40 stack.c > *** stack.c 11 Jul 2002 19:29:08 -0000 1.40 > --- stack.c 14 Aug 2002 23:17:59 -0000 > *************** print_frame_info_base (struct frame_info > *** 398,403 **** > --- 398,408 ---- > print_frame (fi, level, source, args, sal); > > source_print = (source == SRC_LINE || source == SRC_AND_LOC); > + if (sal.symtab != NULL) > + { > + current_source_symtab = sal.symtab; > + current_source_line = sal.line; > + } > > if (source_print && sal.symtab) > { > *************** print_frame_info_base (struct frame_info > *** 410,419 **** > if (!done) > { > if (print_frame_info_listing_hook) > ! { > ! print_frame_info_listing_hook (sal.symtab, sal.line, sal.line + 1, 0); > ! current_source_symtab = sal.symtab; > ! } > else > { > /* We used to do this earlier, but that is clearly > --- 415,421 ---- > if (!done) > { > if (print_frame_info_listing_hook) > ! print_frame_info_listing_hook (sal.symtab, sal.line, sal.line + 1, 0); > else > { > /* We used to do this earlier, but that is clearly > >