From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17835-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 15920 invoked by alias); 20 Aug 2002 14:36:26 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15880 invoked from network); 20 Aug 2002 14:36:24 -0000
Received: from unknown (HELO localhost.redhat.com) (66.30.197.194)
  by sources.redhat.com with SMTP; 20 Aug 2002 14:36:24 -0000
Received: by localhost.redhat.com (Postfix, from userid 469)
	id A2A4710DCC; Tue, 20 Aug 2002 10:34:31 -0400 (EDT)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15714.21367.161116.563645@localhost.redhat.com>
Date: Tue, 20 Aug 2002 07:36:00 -0000
To: gdb-patches@sources.redhat.com
Cc: 
Subject: Re: [RFA] infcmd.c print vector registers in hex only
In-Reply-To: <15712.24703.29805.941875@localhost.redhat.com>
References: <15712.24703.29805.941875@localhost.redhat.com>
X-SW-Source: 2002-08/txt/msg00585.txt.bz2

Elena Zannoni writes:
 > 
 > Doing this simplification allows to get rid of a function (for now,
 > more later) in rs6000-tdep.c. Such function is entirely a duplicate of
 > do_registers_info, except for this patch.
 > 
 > The reason behind this is that vector registers use up a lot of
 > screen real estate, especially the 128 bit ones (altivec registers).
 > 
 > Elena
 > 

To clarify:
With this patch each register is printed like this:
(gdb) info reg vr0
vr0            {uint128 = 0x00000000000000000000000000000000, v4_float = {0x0, 
    0x0, 0x0, 0x0}, v4_int32 = {0x0, 0x0, 0x0, 0x0}, v8_int16 = {0x0, 0x0, 
    0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v16_int8 = {0x0 <repeats 16 times>}}

while w/o the patch:
(gdb) info reg vr0
vr0            {uint128 = 0x00000000000000000000000000000000, v4_float = {0x0, 
    0x0, 0x0, 0x0}, v4_int32 = {0x0, 0x0, 0x0, 0x0}, v8_int16 = {0x0, 0x0, 
    0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v16_int8 = {0x0 <repeats 16 times>}} {
  uint128 = 0x00000000000000000000000000000000, v4_float = {0, 0, 0, 0}, 
  v4_int32 = {0, 0, 0, 0}, v8_int16 = {0, 0, 0, 0, 0, 0, 0, 0}, 
  v16_int8 = '\0' <repeats 15 times>}


I will check this in later today, if there are no objections.

Elena


 > 2002-08-18  Elena Zannoni  <ezannoni@redhat.com>
 > 
 > 	* infcmd.c (do_registers_info): Print vector registers in hex
 > 	format only.
 > 
 > Index: infcmd.c
 > ===================================================================
 > RCS file: /cvs/uberbaum/gdb/infcmd.c,v
 > retrieving revision 1.52
 > diff -u -p -r1.52 infcmd.c
 > --- infcmd.c	16 Aug 2002 00:27:45 -0000	1.52
 > +++ infcmd.c	19 Aug 2002 02:51:16 -0000
 > @@ -1632,14 +1632,18 @@ do_registers_info (int regnum, int print
 >  	    }
 >  	  printf_filtered (")");
 >  	}
 > -      /* Else print as integer in hex and in decimal.  */
 >        else
 >  	{
 > +	  /* Print the register in hex.  */
 >  	  val_print (REGISTER_VIRTUAL_TYPE (i), virtual_buffer, 0, 0,
 >  		     gdb_stdout, 'x', 1, 0, Val_pretty_default);
 > -	  printf_filtered ("\t");
 > -	  val_print (REGISTER_VIRTUAL_TYPE (i), virtual_buffer, 0, 0,
 > -		     gdb_stdout, 0, 1, 0, Val_pretty_default);
 > +          /* If not a vector register, print it also in decimal.  */
 > +	  if (TYPE_VECTOR (REGISTER_VIRTUAL_TYPE (i)) == 0)
 > +	    {
 > +	      printf_filtered ("\t");
 > +	      val_print (REGISTER_VIRTUAL_TYPE (i), virtual_buffer, 0, 0,
 > +			 gdb_stdout, 0, 1, 0, Val_pretty_default);
 > +	    }
 >  	}
 >  
 >        /* The SPARC wants to print even-numbered float regs as doubles