From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31485 invoked by alias); 18 Aug 2002 15:52:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31476 invoked from network); 18 Aug 2002 15:52:37 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 18 Aug 2002 15:52:37 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id BA5DA10CC3; Sun, 18 Aug 2002 11:50:45 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15711.49749.307573.367675@localhost.redhat.com> Date: Sun, 18 Aug 2002 08:52:00 -0000 To: Andrew Cagney Cc: Jason R Thorpe , gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Don't complain about unknown OSABI In-Reply-To: <3D5FC00D.50001@ges.redhat.com> References: <3D5FC00D.50001@ges.redhat.com> X-SW-Source: 2002-08/txt/msg00501.txt.bz2 Andrew Cagney writes: > Hello, > > The attached patch removes the warning message that is printed when the > OSABI is unknown (all the sniffers failed). > > When debugging an embedded executable, there is no OSABI info. Hence I > don't think the warning should be issued. This can be seen when > debugging a GCC created, mips-elf executable. > > thoughts? Yes. I am hitting this on powerpc with the e500 port. It also makes the testsuite fail in some spots. So, I like it. Thanks. Elena > Andrew > 2002-08-18 Andrew Cagney > > * osabi.c (gdbarch_init_osabi): Don't complain about an unknown > ABI. > > Index: osabi.c > =================================================================== > RCS file: /cvs/src/src/gdb/osabi.c,v > retrieving revision 1.5 > diff -u -r1.5 osabi.c > --- osabi.c 27 Jul 2002 01:28:43 -0000 1.5 > +++ osabi.c 18 Aug 2002 13:53:49 -0000 > @@ -232,13 +232,8 @@ > > if (osabi == GDB_OSABI_UNKNOWN) > { > - /* Don't complain about not knowing the OS ABI if we don't > - have an inferior. */ > - if (info.abfd) > - fprintf_filtered > - (gdb_stderr, "GDB doesn't recognize the OS ABI of the inferior. " > - "Attempting to continue with the default %s settings", > - bfd_printable_arch_mach (arch_info->arch, arch_info->mach)); > + /* Don't complain about not knowing the OS ABI. Assume the user > + knows what they are doing. */ > return; > } >