From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24823 invoked by alias); 15 Jul 2002 18:18:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24816 invoked from network); 15 Jul 2002 18:18:17 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 15 Jul 2002 18:18:17 -0000 Received: by localhost.redhat.com (Postfix, from userid 469) id C23C5108CA; Mon, 15 Jul 2002 14:16:42 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15667.4490.430617.703701@localhost.redhat.com> Date: Mon, 15 Jul 2002 11:34:00 -0000 To: Pierre Muller Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Avoid Cannot read 0x20000000 on cygwin GDB In-Reply-To: <4.2.0.58.20020715160517.01b27c00@ics.u-strasbg.fr> References: <4.2.0.58.20020715160517.01b27c00@ics.u-strasbg.fr> X-SW-Source: 2002-07/txt/msg00332.txt.bz2 Pierre Muller writes: > This has been discuss long ago, > and I thought it was in CVS already for a long time, > but apparently noone committed it. > > Back in september 200, I probably didn't dare to commit it myself, > but my commit list grew quite a lot since that time! > > See http://sources.redhat.com/ml/gdb-patches/2000-09/msg00107.html > > If I get an second approval from > any of the Blanket Write Privs (as blockframe.c > does not seem to belong to some designated group), > I will commit this ASAP. > > ChangeLog entry: > > 2000-09-12 Pierre Muller > * blockframe.c (get_pc_function_start): return 0 if the minimal symbol > found is not inside a section. > Go ahead. Check it in. It was already approved, back in 2000. Elena > > > $ cvs diff -u -p blockframe.c > Index: blockframe.c > =================================================================== > RCS file: /cvs/src/src/gdb/blockframe.c,v > retrieving revision 1.32 > diff -u -p -r1.32 blockframe.c > --- blockframe.c 2 Jul 2002 19:08:55 -0000 1.32 > +++ blockframe.c 15 Jul 2002 14:13:32 -0000 > @@ -632,6 +632,8 @@ get_pc_function_start (CORE_ADDR pc) > else if ((msymbol = lookup_minimal_symbol_by_pc (pc)) != NULL) > { > fstart = SYMBOL_VALUE_ADDRESS (msymbol); > + if (!find_pc_section (fstart)) > + return 0; > } > else > { > > > > Pierre Muller > Institut Charles Sadron > 6,rue Boussingault > F 67083 STRASBOURG CEDEX (France) > mailto:muller@ics.u-strasbg.fr > Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99