From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54587 invoked by alias); 22 Jun 2017 11:08:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53932 invoked by uid 89); 22 Jun 2017 11:08:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 11:08:52 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DFEFB41A29; Thu, 22 Jun 2017 11:08:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DFEFB41A29 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com DFEFB41A29 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5381C60470; Thu, 22 Jun 2017 11:08:49 +0000 (UTC) Subject: Re: [PATCH 2/2] gdb: Make some test names unique To: Yao Qi , Andrew Burgess References: <86vanoi9zm.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <1565437a-a03e-1fa8-021a-a2d32de69a97@redhat.com> Date: Thu, 22 Jun 2017 11:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86vanoi9zm.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00635.txt.bz2 On 06/22/2017 11:37 AM, Yao Qi wrote: > Andrew Burgess writes: > > >> mi_gdb_test "540-data-evaluate-expression vla1(1)" \ >> - "540\\^done,value=\"1\"" "evaluate filled vla" >> + "540\\^done,value=\"1\"" "evaluate filled vla(1)" > > Do not use "tail parentheses" on the test message, > https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages The wiki doesn't mention it, but I think the rule should only apply when there's a space before the parens. Otherwise, we have a problem with all the tests that call functions, and don't explicitly specify a test name, like: gdb_test "p function(1)" " = 1" We have many such cases, C tests, Python tests, etc: $ grep "[a-z](.*)$" testsuite/gdb.sum | wc -l 1174 I don't think it's worth it, or even a good idea to try to come up with different test names for all of these. In cases like these, I think it's generally possible to avoid the space before the parens. So IMO, we should clarify the rule instead (and the buildbot testresult diffing accordingly, if necessary). Thanks, Pedro Alves