From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-16601-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 24777 invoked by alias); 1 Jul 2002 15:47:39 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 24768 invoked from network); 1 Jul 2002 15:47:35 -0000
Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107)
  by sources.redhat.com with SMTP; 1 Jul 2002 15:47:35 -0000
Received: from localhost.redhat.com (IDENT:kgQBSb3IayW9TlPTC2aXJuPsv3bfblBu@romulus.sfbay.redhat.com [172.16.27.251])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g61FmkQ11391;
	Mon, 1 Jul 2002 08:48:47 -0700
Received: by localhost.redhat.com (Postfix, from userid 469)
	id 1E33A107D6; Mon,  1 Jul 2002 11:46:45 -0400 (EDT)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15648.31077.572892.886182@localhost.redhat.com>
Date: Mon, 01 Jul 2002 08:47:00 -0000
To: Joern Rennecke <joern.rennecke@superh.com>
Cc: gdb-patches@sources.redhat.com, Elena Zannoni <ezannoni@redhat.com>
Subject: Re: Unreviewed patches
In-Reply-To: <3D205F19.1B99290F@superh.com>
References: <3D205F19.1B99290F@superh.com>
X-SW-Source: 2002-07/txt/msg00004.txt.bz2

Joern Rennecke writes:
 > Wed Jun 12 13:20:51 2002  J"orn Rennecke <joern.rennecke@superh.com>
 > 
 > include/gdb:
 >         * sim-sh.h: Add enum constants for sh[1-4], sh3e, sh3?-dsp.

Yes, sorry for the delay.

Is there any real reason to not just have one enum, which included the
dsp registers as well? I mean, if the simulator didn't reuse register
numbers for FP regs and DPS regs, then you could get rid of this ugly
code in interp.c:

    else case 44:
      if (target_dsp)
	RE = val;
    else case 45: case 46: case 47: case 48: case 49: case 50:
[...]
    case 26:
      val = target_dsp ? A0 : FI (1);
      break;
[...]
etc. etc.

And with that you could get rid of the target_dsp variable.


 > sim/sh:
 >         * Makefile (interp.o): Depend on $(srcroot)/include/gdb/sim-sh.h.
 >         * interp.c: Include "gdb/sim-sh.h".
 >         (sim_store_register, sim_fetch_register): Use constants defined there.
 > 
 > http://sources.redhat.com/ml/gdb-patches/2002-06/msg00185.html
 > 
 > Thu Jun 13 23:20:33 2002  J"orn Rennecke <joern.rennecke@superh.com>
 > 


I think the changes below depend on the cgen patches being accepted first.

Elena


 > 
 > sim/sh64:
 >         * arch.c, arch.h, cpu.c, cpu.h, cpuall.h, decode-compact.c: Regenerate.
 >         * decode-compact.h, decode-media.c, decode-media.h: Likewise.
 >         * defs-compact.h, defs-media.h, sem-compact-switch.c: Likewise.
 >         * sem-compact.c, sem-media-switch.c, sem-media.c, sh-desc.c: Likewise.
 >         * sh-desc.h, sh-opc.h: Likewise.
 > 
 > http://sources.redhat.com/ml/gdb-patches/2002-06/msg00490.html
 > 
 > -- 
 > --------------------------
 > SuperH
 > 2430 Aztec West / Almondsbury / BRISTOL / BS32 4AQ
 > T:+44 1454 462330