Re: [PATCH 1/4] Attribute method inlining

Pedro Alves
2020-05-22T15:47:53Z

On 5/21/20 6:18 PM, Hannes Domani via Gdb-patches wrote:
> Am Donnerstag, 21. Mai 2020, 18:42:23 MESZ hat Pedro Alves <palves@redhat.com> Folgendes geschrieben:
>
>> On 5/21/20 4:03 PM, Hannes Domani via Gdb-patches wrote:

>>>> There was a patch for this not that long ago.  Let me try to dig it up.
>>>
>>> You're right, I found it here:
>>> https://sourceware.org/pipermail/gdb-patches/2019-June/158285.html
>>
>> Yes, that's the one!
>>
>>>
>>> So I guess it's not just on Windows that slow.
>>>
>>> And you replied that we maybe should use TOLOWER, ISXDIGIT from libiberty
>>> instead:
>>> https://sourceware.org/pipermail/gdb-patches/2019-June/158518.html
>>
>> This message is actually older than the patch above -- I wrote the patch
>> afterwards.
>>
>> The patch is using the libiberty macros, and avoids the readline clash
>> you run into.  Could you give it a try?
>
> It wasn't immediately obvious to me, but I think you mean this one:
> https://sourceware.org/pipermail/gdb-patches/2019-June/158525.html

Oh, wow, I confused the "158525" in the url with "158285". They looked
the same number to me. Sorry. Yes, I meant that patch as you found out.

>
> I tried it, and as expected, I get the same speedup as with my previous
> test, and strcmp_iw_ordered is now in only ~1.5% of the profiling samples.

Awesome. Let me write some git log / ChangeLog for it and resend it as
a separate thread.

Thanks,
Pedro Alves