From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix alias command not detecting non matching prefix & sometimes asserting.
Date: Tue, 25 Jun 2019 17:42:00 -0000 [thread overview]
Message-ID: <1561484565.1430.1.camel@skynet.be> (raw)
In-Reply-To: <87a7e590uw.fsf@tromey.com>
On Tue, 2019-06-25 at 08:49 -0600, Tom Tromey wrote:
> > > > > > "Philippe" == Philippe Waroquiers <philippe.waroquiers@skynet.be> writes:
>
> Philippe> gdb/ChangeLog
> Philippe> 2019-06-23 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> Philippe> * cli/cli-cmds.c (alias_command): Compare the alias prefix
> Philippe> with the command prefix.
>
> Philippe> gdb/testsuite/ChangeLog
> Philippe> 2019-06-23 Philippe Waroquiers <philippe.waroquiers@skynet.be>
>
> Philippe> * gdb.base/alias.exp: Test non matching/non existing prefixes.
>
> Thank you for the patch. This is ok.
Thanks for the review, pushed (after updating the ChangeLogs ...)
Philippe
prev parent reply other threads:[~2019-06-25 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 15:41 Philippe Waroquiers
2019-06-25 14:49 ` Tom Tromey
2019-06-25 17:42 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561484565.1430.1.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox