From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41032 invoked by alias); 29 Sep 2016 01:52:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41021 invoked by uid 89); 29 Sep 2016 01:52:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Sep 2016 01:52:19 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 72B8B12B7; Thu, 29 Sep 2016 01:52:18 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8T1qGf6002705; Wed, 28 Sep 2016 21:52:17 -0400 Subject: Re: [PATCH master/7.12] PR 20627: Use resume_stop to stop lwp To: Yao Qi , gdb-patches@sourceware.org References: <1475105417-23047-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <155fa545-c9c5-24a0-3174-eda4c3f55a07@redhat.com> Date: Thu, 29 Sep 2016 02:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1475105417-23047-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00407.txt.bz2 On 09/28/2016 07:30 PM, Yao Qi wrote: > Commit 049a8570 (Use target_continue{,_no_signal} instead of target_resume) > replaces the code stopping lwp with target_continue_no_signal in > target_stop_and_wait, like this, > > - resume_info.thread = ptid; > - resume_info.kind = resume_stop; > - resume_info.sig = GDB_SIGNAL_0; > - (*the_target->resume) (&resume_info, 1); > + target_continue_no_signal (ptid); > > the replacement is not equivalent, and it causes PR 20627. This patch > is just to revert that change. > > Regression testing it on x86_64-linux. > > gdb/gdbserver: > > 2016-09-28 Yao Qi > > PR gdbserver/20627 > * target.c (target_stop_and_wait): Don't call > target_continue_no_signal, use resume_stop instead. OK. Thanks, Pedro Alves