From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HxgpMSioBWZdwBkAWB0awg (envelope-from ) for ; Thu, 28 Mar 2024 13:26:00 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=oSKhuwhn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B83961E0C0; Thu, 28 Mar 2024 13:26:00 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A086B1E030 for ; Thu, 28 Mar 2024 13:25:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 115903858C55 for ; Thu, 28 Mar 2024 17:25:58 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 08F953858D1E for ; Thu, 28 Mar 2024 17:25:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08F953858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08F953858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711646738; cv=pass; b=mF/ePFKgq8mUud/PPMteoD+aMF0k6NEX3/BXrgjtLhSMOAtdAP5OtPc8GPzGTc6IAXVV+FCCDl985bIHxVUEmkTl1Q17jDS536KTHETkRNBU7BQ9tSPM+0TIA3cx1ch+S6atMpiQmHb4CJ77ReUzLPN92H5wMxM9+c0OAjf9XW8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711646738; c=relaxed/simple; bh=HKVzX1yybozRIlCyz38mL5GYl8QNlWxwZhXJ6ugTvuE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qjjUhKKJHp8ReBWCwXt/khSacHeKrQGF3nhkj7/p5enV4rDtV2DBm1cebRwSy0Rsde5p/+nb9Vv819cbtefakxSNb0A4o6CA3zMxdo08u+KWX30c0S3C1+SFeQaoB6cD2/NbENHEi21oBzypE8rdF8fVPhgElYAtvXt//OleL5w= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4V59RF71Jmz47pW; Thu, 28 Mar 2024 17:25:29 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V59RF62bDz444v; Thu, 28 Mar 2024 17:25:29 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711646729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C29LF0yQLxJZUawekIiq0paP1HzTqaiEKUBGRZmuSJk=; b=oSKhuwhn9TdCy25+6R4NBz86qPJhBruth3BuLb8Pr5V+Do7eiGnpRP4gDDjOReMDTLGb2k fnownlpbd/0Rq19YXBP/joePgf9vuuHVfSJnzBnIn/2d82G1L7ObVdp5x7KjZTjk0h/OCH mEppcgaWRxaBZbDFFpdvN1txAY4zC82BzqiLAwfV7Trl+4LxO+x4bxNfRXhDpBlzpU0lkN vPwhwCg7cyPMzwnrUC/XhyMWg+e2LvRf0e7D7lWnHO6UY5rlguMTibrr5/9Et77feMaSlz Y9Cg1iySywzCPkv7AC3FlcdX9sjS3lI2ly3vuzQ81KjkRusVZSNNU4pa+ZdnRw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711646729; a=rsa-sha256; cv=none; b=Z/sj4M5Ka5xa//KZu6U+DIfsKLspADIsE3FjkKNL6n9l1rZ82bQfX55R0qGolAASAPOFC8 EHzCmAb4PDQaKLnA46iEsiY0Bl5B7Y8MaDphapIQlCbUG9iimS7dBqQOMNBeTlAnJDn2PI J+ijLb207LCUb4CW9L2k4qjmA6jKhyh19bUG0yzLPCRvcNVHxl0KzG4w0SOFuJjaBmXL16 p4PLyZuVT68fXWO3sactEX9A+geh7mu1cTgzppGYFu1oNI0NToRosEpcWZD1CileudV3gp 7/oqip9v+0COk9DIoXcy9wUqcykordUZLDDgrODr6iY8za+IOUD2hfsVHF1vqw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711646729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C29LF0yQLxJZUawekIiq0paP1HzTqaiEKUBGRZmuSJk=; b=Nlr7i/VwogwJMB4fvmamUZKDJvK+zVHk0HVA+CyD4FU9tbsY2o+VE3pYofc+U1RyS6ZRor gZ71wi29f4LTlvNmkk/Qvts1GpnJ+HchnvK90HN3nsuFQ9GR65rq1uWkFA+qZNYQqE5VN1 y6lNdkUq0Nea1hrB67AlNZL6SNJFtdIO2cd8YRqMVT8eTkKQzWLqTzIdNkkQhoKt7fKpi7 i7XGnEnNgsiH5ClAk+47zBe0haroNA3E0vobUvxQU5mnV76rw3MY1bu1PtqkIU4bsjcU4f yQciwim2Q5FXEGiK301B3vQL6jR57sB9/4w69Z+OntSSuaSNRXtuzJ3mYu5u+A== Received: from [10.255.0.190] (unknown [208.118.171.245]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V59RF5F9Pz1HXZ; Thu, 28 Mar 2024 17:25:29 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <155f231f-eaed-41ac-a131-9bf756085e1a@FreeBSD.org> Date: Thu, 28 Mar 2024 13:25:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Make pascal_language::print_type handle varstring==nullptr Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240327164031.1582317-1-tom@tromey.com> From: John Baldwin In-Reply-To: <20240327164031.1582317-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/27/24 12:40 PM, Tom Tromey wrote: > PR gdb/31524 points out a crash when pascal_language::print_type is > called with varstring==nullptr. This crash is a regression arising > from the printf/pager rewrite -- that indirectly removed a NULL check > from gdb's "puts". > > This patch instead fixes the problem by adding a check to print_type. > Passing nullptr here seems to be expected in other places (e.g., there > is a call to type_print like this in expprint.c), and other > implementations of this method (or related helpers) explicitly check > for NULL. > > I didn't write a test case for this because it seemed like overkill > for a Pascal bug that only occurs with -i=mi. However, if you want > one, let me know and I will do it. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31524 Seems obvious to me. I think it's fine without a test case. Approved-By: John Baldwin -- John Baldwin