From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46057 invoked by alias); 3 Jun 2019 20:24:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46049 invoked by uid 89); 3 Jun 2019 20:24:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:524 X-HELO: mailsec118.isp.belgacom.be Received: from mailsec118.isp.belgacom.be (HELO mailsec118.isp.belgacom.be) (195.238.20.114) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 03 Jun 2019 20:24:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1559593483; x=1591129483; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=R1SILPji1igE7cydrVTZwaMXQydTO2dNJC2PQLAV/+8=; b=kYxAsyGOc68H7Nqed0T46mx5n3Tgexo0lp4gfJX+PeoEXTtU0IK1vR2I Tct4eNoBXYOkTO3dkX2CQxQZmATKuw==; Received: from 161.32-242-81.adsl-dyn.isp.belgacom.be (HELO md) ([81.242.32.161]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 03 Jun 2019 22:24:40 +0200 Message-ID: <1559593480.1454.50.camel@skynet.be> Subject: Re: [RFAv2 1/4] Add highlight style, title style, fputs_highlighted. Improve 'show style' From: Philippe Waroquiers To: Tom Tromey Cc: gdb-patches@sourceware.org Date: Mon, 03 Jun 2019 20:24:00 -0000 In-Reply-To: <87tvd6msam.fsf@tromey.com> References: <20190601212331.12085-1-philippe.waroquiers@skynet.be> <20190601212331.12085-2-philippe.waroquiers@skynet.be> <87tvd6msam.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00047.txt.bz2 On Mon, 2019-06-03 at 12:34 -0600, Tom Tromey wrote: > > > > > > "Philippe" == Philippe Waroquiers writes: > > Philippe> +fputs_highlighted (const char *str, compiled_regex &highlight, > > I think this can be "const compiled_regex &". This is ok with this > change (if it's not possible, it is ok without the change). Pushed the series after doing the above change. Thanks for the reviews Philippe