From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5693 invoked by alias); 31 May 2019 15:29:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5566 invoked by uid 89); 31 May 2019 15:29:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=department X-HELO: mailsec108.isp.belgacom.be Received: from mailsec108.isp.belgacom.be (HELO mailsec108.isp.belgacom.be) (195.238.20.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 May 2019 15:29:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1559316581; x=1590852581; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=za3SkLq1mr/O/Cc7CektFAXMhkltah9BdulRYT+Xhks=; b=Ya5v3bKbDCkNWkhBMyNBX7d77CnNXlZyTX3NDnQQfeyHfiEXhCnux3jH UR5OmhSVnXEtM+gCx2rgHS73ozF/Yw==; Received: from 161.32-242-81.adsl-dyn.isp.belgacom.be (HELO md) ([81.242.32.161]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 31 May 2019 17:29:39 +0200 Message-ID: <1559316578.1454.43.camel@skynet.be> Subject: Re: [RFAv4 0/5] Implement | (pipe) command. From: Philippe Waroquiers To: Pedro Alves , gdb-patches@sourceware.org Date: Fri, 31 May 2019 15:29:00 -0000 In-Reply-To: References: <20190530142106.25487-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00752.txt.bz2 On Fri, 2019-05-31 at 15:41 +0100, Pedro Alves wrote: > On 5/30/19 3:21 PM, Philippe Waroquiers wrote: > > Implement | (pipe) command. > > > > This patch series adds the pipe command, that allows to send the output > > of a GDB command to a shell command. > > > > This is the fourth version of the patch, handling the additional > > comments of Pedro. > > The doc, help and NEWS are changed in this fourth version, so must be > > re-reviewed. > > This version looks good to me, apart for the comment I sent about NEWS. > > From the nit department, in the testcase patch, in the last test, > use lowercase for "Delimiter" in the test message. > > With those fixed, this is good to go. Please push. Pushed after fixing the above 2 things. Thanks for the reviews Philippe