From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-156348-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 127008 invoked by alias); 25 May 2019 20:12:49 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 126999 invoked by uid 89); 25 May 2019 20:12:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-22.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: mailsec117.isp.belgacom.be
Received: from mailsec117.isp.belgacom.be (HELO mailsec117.isp.belgacom.be) (195.238.20.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 25 May 2019 20:12:48 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;  d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail;  t=1558815169; x=1590351169;  h=message-id:subject:from:to:date:in-reply-to:references:   mime-version:content-transfer-encoding;  bh=q27gh0dRYt4mQEK9FT2Il9cfNPdBzurV5tApThfeF+Y=;  b=KekJT7S2Wvz8fqvMWRQHaO6gxrQ6Qx7iXKEf59RWGlUp6IjprZQYKJUs   Lu4l3I5MaNhnJPzelECAzZFZEYAYzQ==;
Received: from 161.32-242-81.adsl-dyn.isp.belgacom.be (HELO md) ([81.242.32.161])  by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 25 May 2019 22:12:47 +0200
Message-ID: <1558815166.1454.24.camel@skynet.be>
Subject: Re: [PATCH 20/24] Make "frame apply" support -OPT options
From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Date: Sat, 25 May 2019 20:12:00 -0000
In-Reply-To: <20190522205327.2568-21-palves@redhat.com>
References: <20190522205327.2568-1-palves@redhat.com>	 <20190522205327.2568-21-palves@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2019-05/txt/msg00580.txt.bz2

Some typos in the test.

On Wed, 2019-05-22 at 21:53 +0100, Pedro Alves wrote:
> @@ -3095,44 +32diff --git a/gdb/testsuite/gdb.base/options.exp b/gdb/testsuite/gdb.base/options.exp
> index a4bd686fe5f..df5d86c0ece 100644
> --- a/gdb/testsuite/gdb.base/options.exp
> +++ b/gdb/testsuite/gdb.base/options.exp
> +	# tfaas is silent on comand error by design.  This procedure
comand -> command

>  # Miscelaneous tests.
Miscelaneous -> Miscellaneous
(maybe the same one as before?)

>  proc_with_prefix test-misc {variant} {
>      global all_options
> @@ -731,13 +807,28 @@ foreach_with_prefix cmd {
>      test-enum $cmd
>  }
>  
> -# Run the print integration tests.
> -test-print ""
> +# Run the print integration tests, both as "standalone", and under
> +# "frame apply".  The latter checks that the "frame apply ... COMMAND"
> +# commands recurse the completion machinery for COMMAND completion
Not very clear what commands (with s) we speak about here ...