From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99075 invoked by alias); 25 May 2019 07:43:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99064 invoked by uid 89); 25 May 2019 07:43:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=option's, DOC X-HELO: mailsec117.isp.belgacom.be Received: from mailsec117.isp.belgacom.be (HELO mailsec117.isp.belgacom.be) (195.238.20.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 25 May 2019 07:43:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1558770210; x=1590306210; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=rj/+2+eG/0Wf01ooHOvppH2jPkjfKEtRuB5Xr76379w=; b=ChDt/+y+3Vs8RUf/A1a8An/iS64ON1V5jrVCobNp4qw4KtfvTCI5HrlN 3u+fkeZ55EPY2Figy3kJbZuhbLEK8A==; Received: from 161.32-242-81.adsl-dyn.isp.belgacom.be (HELO md) ([81.242.32.161]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 25 May 2019 09:43:28 +0200 Message-ID: <1558770207.1454.19.camel@skynet.be> Subject: Re: [PATCH 12/24] Introduce generic command options framework From: Philippe Waroquiers To: Pedro Alves , gdb-patches@sourceware.org Date: Sat, 25 May 2019 07:43:00 -0000 In-Reply-To: <20190522205327.2568-13-palves@redhat.com> References: <20190522205327.2568-1-palves@redhat.com> <20190522205327.2568-13-palves@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00573.txt.bz2 While quickly scanning the patch, I found a few typos ... On Wed, 2019-05-22 at 21:53 +0100, Pedro Alves wrote: > diff --git a/gdb/cli/cli-option.c b/gdb/cli/cli-option.c > new file mode 100644 > index 00000000000..432555a953f > --- /dev/null > +++ b/gdb/cli/cli-option.c ... > +/* Helper for build_help. Appends an indended version of DOC into > + HELP. */ indended -> indented > + > +static void > +append_indended_doc (const char *doc, std::string &help) Same in the function name > diff --git a/gdb/cli/cli-option.h b/gdb/cli/cli-option.h > new file mode 100644 > index 00000000000..437fc09a61b > --- /dev/null > +++ b/gdb/cli/cli-option.h ... > +struct option_def > +{ > + /* The ctor is protected because you're supposed to construct using > + one of bool_option_def, etc. below. */ > +protected: > + typedef void *(erased_var_address_ftype) (); > + > + /* Construct an option. NAME_ is the option's name. VAR_TYPE_ > + defines the option's type. ERASED_VAR_ADDRESS_ is a pointer to > + the option's control variable. SHOW_CMD_CB_ is a pointer to Isn't ERASED_VAR_ADDRESS_ the address of a function ? > diff --git a/gdb/testsuite/gdb.base/options.exp b/gdb/testsuite/gdb.base/options.exp > new file mode 100644 > index 00000000000..924d7aa544e > --- /dev/null > +++ b/gdb/testsuite/gdb.base/options.exp ... > > +# Miscelaneous tests. Miscellaneous