From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46993 invoked by alias); 25 May 2017 10:12:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46974 invoked by uid 89); 25 May 2017 10:12:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f41.google.com Received: from mail-wm0-f41.google.com (HELO mail-wm0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 May 2017 10:12:22 +0000 Received: by mail-wm0-f41.google.com with SMTP id b84so85902358wmh.0 for ; Thu, 25 May 2017 03:12:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=gM/8W4xRljjGwWgJUeG3ezFjkrx5RjkdISPEGt+VEFw=; b=Vk5N2c37Yctsum6M1/EER3Aaijb7H7KrJAm8a+Q/9YqBTDX7F10Dqd3n+SH9JCLVi5 H6OicKFdl2SUGy47pRsXRmeoDbEuZh1P+jfNUQJTidAUMuqNPfBdp5f8jlc71lJfB0L8 1+HE46ZCTtYe3ECcI2gT+ioidz3fP8GsCoQUjJiW9QZrVijjbEKCsV3t4QXKLLm92d1U IeXv58dZyDm7hKIKvebb/JIm7dG29xut4IaZ5ZGBCtX9TAcXvqAGch38XUJ0tkStll1G CVp7YVRMkTWMq3PvJrwap339XlZtynypKaE4+1Qn+QMUpjFcftKdgTwIfSN2K4L9wDkx iYMA== X-Gm-Message-State: AODbwcAd3AVI0GoQNaqG5pSjz/QaA+r6VD94qB8WChvY9DoI2ho9Qgkt Ac+yeS1ULTGHNPeA X-Received: by 10.223.178.150 with SMTP id g22mr21552150wrd.158.1495707144240; Thu, 25 May 2017 03:12:24 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id m38sm9226675wrm.4.2017.05.25.03.12.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 May 2017 03:12:23 -0700 (PDT) Subject: Re: GDB 7.99.91 MinGW compilation error in cli-script.c To: Joel Brobecker , Eli Zaretskii References: <83fug35v70.fsf@gnu.org> <83y3tt2ow0.fsf@gnu.org> <83vaox2j0w.fsf@gnu.org> <7017128a-7b51-5436-657b-58807d04eb02@redhat.com> <83vaouns1q.fsf@gnu.org> <837f18ohr2.fsf@gnu.org> <54594002-5d70-9ff8-c481-0cbfc8c68c7b@redhat.com> <834lwam7n4.fsf@gnu.org> <20170524193716.5arjibe4s5efvgj7@adacore.com> Cc: simon.marchi@polymtl.ca, gdb-patches@sourceware.org From: Pedro Alves Message-ID: <15568468-0852-d786-8777-4adbd16825a0@redhat.com> Date: Thu, 25 May 2017 10:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170524193716.5arjibe4s5efvgj7@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00536.txt.bz2 On 05/24/2017 08:37 PM, Joel Brobecker wrote: >> +2017-05-24 Eli Zaretskii >> + >> + * common/common-utils.h (REPLACE_TO_STRING) [__MINGW32__]: Define >> + to 1 if std::to_string is not available. This: >> + (std::to_string) [REPLACE_TO_STRING]: Provide a replacement >> + implementation. Should really be: (gdb::to_string): Define. and you need an entry for the cli/cli-script.c change, like: * cli/cli-script.c (user_args::insert_args): Use it. Otherwise this version of the patch is OK with me. > Did we consider the option of perhaps only pushing this patch > to the 8.0 branch, and require MinGW 5.x for the current master? > If we did it that way, it would allow us to avoid remembering > that we need to use gdb::to_string instead of std::to_string. That'd be fine with me, FWIW. Thanks, Pedro Alves