From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75491 invoked by alias); 28 Apr 2019 05:19:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75455 invoked by uid 89); 28 Apr 2019 05:18:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=activities, pushing, painful, detect X-HELO: mailsec104.isp.belgacom.be Received: from mailsec104.isp.belgacom.be (HELO mailsec104.isp.belgacom.be) (195.238.20.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 28 Apr 2019 05:18:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1556428736; x=1587964736; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=/myYWlTQm370EGTq3c46ZvzkRJjeWgg0CRbdzNajNEk=; b=eCbztQLpf8x4c1BQkgx8S18t8s6zQeOP3Zb5nIj89METV7HbPdYut07D 5bja1P6y1LV9Ds8uiJZ/N+BfBSdkqw==; Received: from unknown (HELO md) ([109.129.151.59]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 28 Apr 2019 07:18:43 +0200 Message-ID: <1556428722.1511.1.camel@skynet.be> Subject: Re: [RFA] Have 'thread|frame apply' style their output. From: Philippe Waroquiers To: Simon Marchi , Tom Tromey Cc: gdb-patches@sourceware.org Date: Sun, 28 Apr 2019 05:19:00 -0000 In-Reply-To: References: <20190309225932.14568-1-philippe.waroquiers@skynet.be> <874l6mcckt.fsf@tromey.com> <1556368938.22002.19.camel@skynet.be> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00608.txt.bz2 On Sat, 2019-04-27 at 15:19 -0400, Simon Marchi wrote: > On 2019-04-27 8:42 a.m., Philippe Waroquiers wrote: > > Thanks for the review. Pushed after fixing (for the "const?" comment, > > I have added an explanation to clarify). > > > > Philippe > > Hi Philippe, > > There is one more spot to update, which you'll find if you build with --with-guile: > > CXX guile/guile.o > /home/simark/src/binutils-gdb/gdb/guile/guile.c: In lambda function: > /home/simark/src/binutils-gdb/gdb/guile/guile.c:310:62: error: too few arguments to function ‘std::__cxx11::string execute_command_to_string(const char*, int, bool)’ > to_string_res = execute_command_to_string (command, from_tty); > ^ > In file included from /home/simark/src/binutils-gdb/gdb/guile/guile.c:29: > /home/simark/src/binutils-gdb/gdb/gdbcmd.h:140:20: note: declared here > extern std::string execute_command_to_string (const char *p, int from_tty, > ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > I presume you'll want to pass false in this case, since it's specifically meant to > send the output to a string, where we don't want styling? Hello Simon, I have just pushed a follow-up to fix the above. At the same time, I saw that I forgot to copy/paste the ChangeLog from the commit message to the ChangeLog file. I fixed this also. Sorry for the breakage, I have now added --with-guile as default. Philippe NB: this ChangeLog is a nightmare to produce (and maintain for each version of a patch). And then still a final copy-paste from commit log to the real file to not forget. (to avoid merge conflicts). The only good point of ChangeLog is that this is reminding me of the 80s, when I was young, and there was no good source control system, and we were all proudly indicating in each source file what we changed at what date :). This ChangeLog is just slowing down the free software development by moving away resources to useless painful administrative activities. This must have been invented by an evil person that hates free software :). I think I will now type it directly (but at the end of the file), and move it at the beginning of the file just before pushing. At least, it reduces the nr of operations (and I have a script I am running to automatically do some checks before pushing, that I will make detect I forgot to move it).