From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44248 invoked by alias); 21 Apr 2019 09:40:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44238 invoked by uid 89); 21 Apr 2019 09:40:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mailsec119.isp.belgacom.be Received: from mailsec119.isp.belgacom.be (HELO mailsec119.isp.belgacom.be) (195.238.20.115) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 21 Apr 2019 09:40:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1555839624; x=1587375624; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=I/UxqR2RRd7SINOJRA2KzHoRvDRGrtg7KyzjAO9ROk8=; b=nViXZYes+JtVYZAg5ol8Isn9rTGPQ8q69wmjppIN9tsl83jm/fC5N/To 69/L8E3RMFRHaVjFFlwUOV9z6CY70g==; Received: from 45.123-131-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.131.123.45]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 21 Apr 2019 11:40:22 +0200 Message-ID: <1555839622.6208.17.camel@skynet.be> Subject: Re: [RFA 2/4] Implement | (pipe) command. From: Philippe Waroquiers To: Eli Zaretskii Cc: gdb-patches@sourceware.org Date: Sun, 21 Apr 2019 09:40:00 -0000 In-Reply-To: <83r29w9bpw.fsf@gnu.org> References: <20190420212153.30934-1-philippe.waroquiers@skynet.be> <20190420212153.30934-3-philippe.waroquiers@skynet.be> <83r29w9bpw.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00403.txt.bz2 On Sun, 2019-04-21 at 08:19 +0300, Eli Zaretskii wrote: > > From: Philippe Waroquiers > > Cc: Philippe Waroquiers > > Date: Sat, 20 Apr 2019 23:21:51 +0200 > > > > + if (shell_command_status > 0) > > + { > > + if (WIFEXITED (shell_command_status)) > > + warning (_("shell command \"%s\" exit status %d"), shell_command, > > + WEXITSTATUS (shell_command_status)); > > + else if (WIFSIGNALED (shell_command_status)) > > + warning (_("shell command \"%s\" exit with signal %d"), shell_command, > > + WTERMSIG (shell_command_status)); > > These macros will need to be ported to MinGW, since the current > definitions in gdb_wait.h are for Posix systems (and never used on > anything other than that). Gnulib has replacements, but they are less > functional on Windows than I'd like them to be, in particular when the > shell program exited due to a signal. I can provide better > replacements if you want. It would be nice to have better replacement for Windows, as I do not have the knowledge and needed setup to test for this platform. Thanks for the review. Philippe