From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-14404-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 19695 invoked by alias); 19 Apr 2002 16:06:59 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 19643 invoked from network); 19 Apr 2002 16:06:53 -0000
Received: from unknown (HELO cygnus.com) (205.180.83.203)
  by sources.redhat.com with SMTP; 19 Apr 2002 16:06:53 -0000
Received: from localhost.redhat.com (remus.sfbay.redhat.com [172.16.27.252])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id JAA16714;
	Fri, 19 Apr 2002 09:06:50 -0700 (PDT)
Received: by localhost.redhat.com (Postfix, from userid 469)
	id C7CDD11435; Fri, 19 Apr 2002 12:06:25 -0400 (EDT)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15552.16512.955981.455419@localhost.redhat.com>
Date: Fri, 19 Apr 2002 09:06:00 -0000
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Elena Zannoni <ezannoni@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: gdb.asm/asm-source.exp creation of arch.inc doesn't work for relative ${srcdir}
In-Reply-To: <20020416125646.A25162@nevyn.them.org>
References: <20020416010713.A32200@nevyn.them.org>
	<15548.13764.336835.513002@localhost.redhat.com>
	<20020416125646.A25162@nevyn.them.org>
X-SW-Source: 2002-04/txt/msg00625.txt.bz2

Daniel Jacobowitz writes:
 > On Tue, Apr 16, 2002 at 10:31:32AM -0400, Elena Zannoni wrote:

 > >  
 > > -set insn_file ${srcdir}/${subdir}/${asm-arch}.inc
 > > -remote_exec build "rm -f ${objdir}/${subdir}/arch.inc"
 > 
 > Please don't delete this line.  If you remote_download onto a dangling
 > symlink, you get an error.  I don't know what happens if you remote
 > download onto a normal symlink, but it runs a risk of clobbering
 > something in ${srcdir}.
 > 

Actually there would be no symlink at all after this patch.
But I'll leave the line in anyway, just in case.

This is what I checked in:

2002-04-19  Elena Zannoni  <ezannoni@redhat.com>

	* gdb.asm/asm-source.exp: Don't use a symlink, just copy the
	instruction file directly into the build tree.  Clean up at end of
	test.

Index: asm-source.exp
===================================================================
RCS file: /cvs/uberbaum/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.21
diff -u -p -r1.21 asm-source.exp
--- asm-source.exp	8 Apr 2002 00:01:06 -0000	1.21
+++ asm-source.exp	19 Apr 2002 16:05:10 -0000
@@ -87,9 +87,8 @@ set binfile ${objdir}/${subdir}/${testfi
 set src1 ${srcdir}/${subdir}/asmsrc1.s
 set src2 ${srcdir}/${subdir}/asmsrc2.s
 
-set insn_file ${srcdir}/${subdir}/${asm-arch}.inc
-remote_exec build "rm -f ${objdir}/${subdir}/arch.inc"
-remote_exec build "ln -s ${insn_file} ${objdir}/${subdir}/arch.inc"
+remote_exec build "rm -f ${subdir}/arch.inc"
+remote_download host ${srcdir}/${subdir}/${asm-arch}.inc ${subdir}/arch.inc
 
 if { "${asm-flags}" == "" } {
     #set asm-flags "-Wa,-gstabs,-I${srcdir}/${subdir},-I${objdir}/${subdir}"
@@ -278,3 +277,4 @@ gdb_test "print staticvar" ".* = 5" "loo
 gdb_test "disassem foostatic" ".*<foostatic>:.*End of assembler dump." \
 	"look at static function"
 
+remote_exec build "rm -f ${subdir}/arch.inc"