From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Alan Hayward <Alan.Hayward@arm.com>, Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH] infun debug: Use correct target pid
Date: Sat, 30 Mar 2019 10:05:00 -0000 [thread overview]
Message-ID: <1553940313.1854.0.camel@skynet.be> (raw)
In-Reply-To: <4592505B-96DA-443B-B343-00BBBBDB777D@arm.com>
On Mon, 2019-03-25 at 16:58 +0000, Alan Hayward wrote:
> > On 25 Mar 2019, at 16:21, Tom Tromey <tom@tromey.com> wrote:
> >
> > > > > > > "Alan" == Alan Hayward <Alan.Hayward@arm.com> writes:
> >
> > Alan> The infrun debug reads the id for the exited thread from the ws value.
> > Alan> However, this is always 0, causing an assert in find_inferior_pid.
> >
> > Alan> Instead, the id should be read from the wait return value.
> >
> > FWIW this is already being discussed in another thread:
> >
> > https://sourceware.org/ml/gdb-patches/2019-03/msg00516.html
> >
> > Tom
>
> !!! Yes, I totally missed that! Complete coincidence too.
> I’ll drop my patch.
I have just sent an RFAv2
https://sourceware.org/ml/gdb-patches/2019-03/msg00758.html
that fixes the above and improves some other related tracing.
Philippe
prev parent reply other threads:[~2019-03-30 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 16:18 Alan Hayward
2019-03-25 16:22 ` Tom Tromey
2019-03-25 16:58 ` Alan Hayward
2019-03-30 10:05 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553940313.1854.0.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox