From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11759 invoked by alias); 9 Apr 2002 01:19:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11752 invoked from network); 9 Apr 2002 01:19:11 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 9 Apr 2002 01:19:11 -0000 Received: from localhost.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id SAA08351; Mon, 8 Apr 2002 18:19:09 -0700 (PDT) Received: by localhost.redhat.com (Postfix, from userid 469) id BFC3A11404; Mon, 8 Apr 2002 21:18:50 -0400 (EDT) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15538.16762.410385.501030@localhost.redhat.com> Date: Mon, 08 Apr 2002 18:19:00 -0000 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] rs6000-tdep.c: Use set_gdbarch_print_insn() In-Reply-To: <1020409001204.ZM22336@localhost.localdomain> References: <1020409001204.ZM22336@localhost.localdomain> X-SW-Source: 2002-04/txt/msg00338.txt.bz2 Kevin Buettner writes: > I've just committed the patch below... Kevin, tm_print_insn shouldn't be used/needed anymore. I have removed gdbtk's uses of tm_print_insn a while back. Elena > > From Jimi X : > * rs6000-tdep.c (rs6000_gdbarch_init): Use set_gdbarch_print_insn(). > > Index: rs6000-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v > retrieving revision 1.45 > diff -u -p -r1.45 rs6000-tdep.c > --- rs6000-tdep.c 8 Apr 2002 22:56:46 -0000 1.45 > +++ rs6000-tdep.c 8 Apr 2002 23:52:06 -0000 > @@ -2536,11 +2536,6 @@ rs6000_gdbarch_init (struct gdbarch_info > gdbarch = gdbarch_alloc (&info, tdep); > power = arch == bfd_arch_rs6000; > > - /* Select instruction printer. */ > - tm_print_insn = arch == power ? print_insn_rs6000 : > - info.byte_order == BFD_ENDIAN_BIG ? print_insn_big_powerpc : > - print_insn_little_powerpc; > - > /* Choose variant. */ > v = find_variant_by_arch (arch, mach); > if (!v) > @@ -2585,6 +2580,14 @@ rs6000_gdbarch_init (struct gdbarch_info > tdep->regoff[i] = off; > off += regsize (v->regs + i, wordsize); > } > + > + /* Select instruction printer. Note: tm_print_insn is still used by > + gdbtk (insight), so we set both tm_print_insn and the gdbarch > + method. */ > + tm_print_insn = arch == power ? print_insn_rs6000 : > + info.byte_order == BFD_ENDIAN_BIG ? print_insn_big_powerpc : > + print_insn_little_powerpc; > + set_gdbarch_print_insn (gdbarch, tm_print_insn); > > set_gdbarch_read_pc (gdbarch, generic_target_read_pc); > set_gdbarch_write_pc (gdbarch, generic_target_write_pc);