From: Elena Zannoni <ezannoni@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA/RFC] Multilibs and gdb.asm
Date: Fri, 05 Apr 2002 13:19:00 -0000 [thread overview]
Message-ID: <15534.5336.562102.896601@localhost.redhat.com> (raw)
In gdb.asm/asm-source.exp, the testsuite passes multilib options to
the assembler according to the compiler syntax.
Obviously this doesn't work, as already noted by Nick Clifton in:
http://sources.redhat.com/ml/gdb-patches/2002-01/msg00282.html
A solution wasn't reached at the time.
I found it useful to just bail out of the test if some multilibs were
detected. At least it reduced the noise in the testsuite results.
Is this too drastic?
Elena
2002-04-05 Elena Zannoni <ezannoni@redhat.com>
* gdb.asm/asm-source.exp: Bail out if multilibs are detected.
Index: asm-source.exp
===================================================================
RCS file: /cvs/uberbaum/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.19
diff -u -p -r1.19 asm-source.exp
--- asm-source.exp 2002/04/05 02:48:23 1.19
+++ asm-source.exp 2002/04/05 21:15:04
@@ -67,10 +67,29 @@ if { "${asm-arch}" == "" } {
gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
}
+# Watch out, we are invoking the assembler, but the testsuite sets multilib
+# switches according to compiler syntax. If we pass these options straight
+# to the assembler, they won't always make sense. If we don't pass them to
+# the assembler, the final link will complain that the object files were
+# built with different defaults. So no matter what we do, we lose. We may as
+# well get out of this test sooner rather than later.
+set dest [target_info name]
+if [board_info $dest exists multilib_flags] {
+ set multilib_flags [board_info $dest multilib_flags]
+ if { "${multilib_flags}" != "" } {
+ gdb_suppress_entire_file "Assembly source test -- multilibs not supported by this test."
+ return;
+ }
+}
+
set testfile "asm-source"
next reply other threads:[~2002-04-05 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-05 13:19 Elena Zannoni [this message]
2002-04-05 13:42 ` Daniel Jacobowitz
2002-04-05 13:50 ` Andrew Cagney
2002-04-05 18:14 ` Michael Snyder
2002-04-05 18:15 ` Michael Snyder
2002-04-05 14:30 ` Fernando Nasser
2002-04-05 15:05 ` Andrew Cagney
2002-04-07 17:10 ` Elena Zannoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15534.5336.562102.896601@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox