From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24541 invoked by alias); 9 Mar 2019 11:18:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24531 invoked by uid 89); 9 Mar 2019 11:18:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Envelope-From:sk:philipp, HX-Languages-Length:905, explain X-HELO: mailsec117.isp.belgacom.be Received: from mailsec117.isp.belgacom.be (HELO mailsec117.isp.belgacom.be) (195.238.20.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 09 Mar 2019 11:18:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1552130323; x=1583666323; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=TdtML46xBpIHIFzSXwCXr8AFU5ILCI1WaptSV740x1w=; b=mhSftyMXCfniMqUGIGCX3rv3Jwe4I5OEf7+yv4jl5ii6XTEtwPvoPZdB xgi9w0407HnJc251m+cNNNoW4epOeQ==; Received: from 147.122-130-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.130.122.147]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 09 Mar 2019 12:18:41 +0100 Message-ID: <1552130320.6197.4.camel@skynet.be> Subject: Re: [RFC 8.3 2/3] Add the "set style source" command From: Philippe Waroquiers To: Tom Tromey , gdb-patches@sourceware.org Date: Sat, 09 Mar 2019 11:18:00 -0000 In-Reply-To: <20190308210433.32683-3-tromey@adacore.com> References: <20190308210433.32683-1-tromey@adacore.com> <20190308210433.32683-3-tromey@adacore.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00205.txt.bz2 On Fri, 2019-03-08 at 14:04 -0700, Tom Tromey wrote: > diff --git a/gdb/NEWS b/gdb/NEWS > index cc7c35c0642..06564311643 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -145,6 +145,12 @@ show style enabled > Enable or disable terminal styling. Styling is enabled by default > on most hosts, but disabled by default when in batch mode. > > +set style sources [on|off] > +show style sources > + Enable or disable source code styling. Source code styling is > + enabled by default, but only takes effect if styling in general is > + enabled, if if GDB was linked with GNU Source Highlight. As already reported by Eli : if if -> and if ? Also, this NEWS entry explains that 'on' takes effect only if styling is on, but neither the help nor the user manual are explaining this. Maybe the help and/or user manual should also explain this ? Thanks Philippe