From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20119 invoked by alias); 19 Mar 2002 17:41:38 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19976 invoked from network); 19 Mar 2002 17:41:32 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 19 Mar 2002 17:41:32 -0000 Received: from localhost.redhat.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id JAA02008; Tue, 19 Mar 2002 09:41:24 -0800 (PST) Received: by localhost.redhat.com (Postfix, from userid 469) id 5D0DD112E4; Tue, 19 Mar 2002 12:41:06 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15511.30770.115770.867801@localhost.redhat.com> Date: Tue, 19 Mar 2002 09:41:00 -0000 To: Alexandre Oliva Cc: gdb-patches@sources.redhat.com Subject: Re: GDB CVS won't build on OSF4.0's cc In-Reply-To: References: <15134.37007.772051.431723@kwikemart.cygnus.com> <15140.51449.939073.693253@kwikemart.cygnus.com> X-Mailer: VM 7.00 under Emacs 20.7.1 X-SW-Source: 2002-03/txt/msg00350.txt.bz2 OK, I think this is fine now, but you forgot one PTR in defs.h, see below. Check it in, thanks. Elena Alexandre Oliva writes: > On Jun 11, 2001, Elena Zannoni wrote: > > > Alexandre Oliva writes: > >> On Jun 6, 2001, Elena Zannoni wrote: > >> > >> > Alex, no. Sorry, but we are trying to get rid of PTR in the > >> > gdb sources [as Kevin pointed out in another message]. > >> > >> Sorry. > >> > >> > Could you 'revert' these changes by changing the definitions to > >> > use void * and deleting the prototypes when they are not needed (everyone > >> > of these can go, except for free_elfinfo, I think). > >> > >> Fixed as follows. Not tested on all relevant architectures. I'd do > >> that after next Monday's GCC snapshot, since I've been building GDB > >> along with GDB lately. Ok to install? > > > Yes, but with the memset calls changes, i.e. remove the casts. > > >> Index: gdb/ChangeLog > >> from Alexandre Oliva > >> > >> * coffread.c: Remove redundant static declarations. Replace > >> occurrences of `PTR' with `void *'. > >> * elfread.c, mdebugread.c, minsyms.c, mipsread.c: Likewise. > > Ok, here's an updated patch, that applies cleanly into mainline and > 5.2 branch, and that adds two more PTR->void* fixes that slipped in > after my original clean-up. Oh, and that removes the (void *) casts > in memset calls that I had introduced in my previous patch. Ok to > install in 5.2 and mainline? With this and the other 2 patches I > posted today (for gdb/defs.h and expect), gdb 5.2 builds successfully > with OSF 4.0's cc. > > Index: gdb/ChangeLog > from Alexandre Oliva > * coffread.c: Remove redundant static declarations. Replace > occurrences of `PTR' with `void *'. > * elfread.c, mdebugread.c, minsyms.c, mipsread.c: Likewise. > * top.h (quit_cover): Likewise. > * defs.h (catch_errors): Likewise. > > Index: gdb/defs.h > =================================================================== > RCS file: /cvs/src/src/gdb/defs.h,v > retrieving revision 1.81 > diff -u -p -r1.81 defs.h > --- gdb/defs.h 2002/02/26 03:29:55 1.81 > +++ gdb/defs.h 2002/03/07 00:23:25 > @@ -1152,7 +1152,7 @@ extern int catch_exceptions (struct ui_o > This function is superseeded by catch_exceptions(). */ > > typedef int (catch_errors_ftype) (PTR); ^^^^ > -extern int catch_errors (catch_errors_ftype *, PTR, char *, return_mask); > +extern int catch_errors (catch_errors_ftype *, void *, char *, return_mask); > > /* Template to catch_errors() that wraps calls to command > functions. */ > > -- > Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/ > Red Hat GCC Developer aoliva@{cygnus.com, redhat.com} > CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org} > Free Software Evangelist Professional serial bug killer