From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40239 invoked by alias); 10 Feb 2019 12:18:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40230 invoked by uid 89); 10 Feb 2019 12:18:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:U*kevinb, our X-HELO: mailsec110.isp.belgacom.be Received: from mailsec110.isp.belgacom.be (HELO mailsec110.isp.belgacom.be) (195.238.20.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Feb 2019 12:18:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1549801090; x=1581337090; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=l+F4nNNDKKCnmUakty99b0O0zTEXuI8RF/+MGdRDZlE=; b=Rj+ECz2nahXIVF1uRufLrYbWy54Qy5inp3YPtNE+OkQtXiS8g81yGzN2 9gR3+kWyjoO0jQekxS4u8WeemH2Dhw==; Received: from 147.122-130-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.130.122.147]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 10 Feb 2019 13:18:07 +0100 Message-ID: <1549801087.12345.10.camel@skynet.be> Subject: Re: [RFA] Fix type_stack leaks in c expression parsing. From: Philippe Waroquiers To: Kevin Buettner Cc: gdb-patches@sourceware.org Date: Sun, 10 Feb 2019 12:18:00 -0000 In-Reply-To: <20190209173134.56bfe46e@f29-4.lan> References: <20190209195000.23057-1-philippe.waroquiers@skynet.be> <20190209173134.56bfe46e@f29-4.lan> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00111.txt.bz2 On Sat, 2019-02-09 at 17:31 -0700, Kevin Buettner wrote: > The actual changes in your patch look good to me. > > One nit regarding the ChangeLog entry though - I think we strive to > make our ChangeLog remarks look like sentences where the first word > is capitalized. So... maybe something like: > > * c-exp.y (direct_abs_decl): Use emplace_back to record the > type_stack. > > If you can think of a better ChangeLog comment, that's fine too. > > Kevin Thanks for the review, pushed after having fixed the ChangeLog as suggested. Philippe