From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85664 invoked by alias); 5 Feb 2019 19:55:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85654 invoked by uid 89); 5 Feb 2019 19:55:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mailsec119.isp.belgacom.be Received: from mailsec119.isp.belgacom.be (HELO mailsec119.isp.belgacom.be) (195.238.20.115) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Feb 2019 19:55:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1549396538; x=1580932538; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=BryBFPDyUup/RWjsxmecizUdQ4j4PUJHcAq+w83UhwU=; b=0YRq3CPK7gCF1w2MEHQGCjNV8OhDO6+cXKknpReWhVmZi34Gn6xX4joU mYX70MI3xDj67teL7GbdiPrqRtWX9Q==; Received: from 147.122-130-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.130.122.147]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 05 Feb 2019 20:55:35 +0100 Message-ID: <1549396534.2630.23.camel@skynet.be> Subject: Re: [RFA] Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp From: Philippe Waroquiers To: Tom Tromey Cc: Kevin Buettner , gdb-patches@sourceware.org Date: Tue, 05 Feb 2019 19:55:00 -0000 In-Reply-To: <875ztypcs3.fsf@tromey.com> References: <20190126223435.9411-1-philippe.waroquiers@skynet.be> <20190203104539.6272f9d8@f29-4.lan> <1549216729.2630.17.camel@skynet.be> <875ztypcs3.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00027.txt.bz2 On Tue, 2019-02-05 at 06:47 -0700, Tom Tromey wrote: > > > > > > "Philippe" == Philippe Waroquiers writes: > > Philippe> The below change was discussed with Tom on irc. > Philippe> Tom pushed a first fix in the splay tree, so it would be easier > Philippe> for me if he (or someone else) could also push this one. > > Did you send them to gcc-patches? > If so and they were approved, let me know and I will commit them > (though maybe not until Monday, depending). > If not, let me know, and I can forward the note, etc. No, I did not send it. It would be really nice if you could take that in charge. Also, there is a leak related to macro definition (but not in splay tree), for which there is a patch series: [RFAv3 0/2] Fix leaks in macro definition https://sourceware.org/ml/gdb-patches/2019-01/msg00567.html This series is still to be reviewed. Thanks Philippe