From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74871 invoked by alias); 3 Feb 2019 17:58:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74814 invoked by uid 89); 3 Feb 2019 17:58:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:be, discussed X-HELO: mailsec108.isp.belgacom.be Received: from mailsec108.isp.belgacom.be (HELO mailsec108.isp.belgacom.be) (195.238.20.104) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 03 Feb 2019 17:58:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1549216732; x=1580752732; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=qeV/STxbnreDg0PoUziUjzN6z/19sYdWtNJnUR1QNAc=; b=Ln8eLlN4Og+tVWlSL0aT5mf5Y4jFOa6KCKr7qQ0Z27r2dgmOD5a4KOHM ImA/PkHDooDBFhricqYWNj8iUqQzkA==; Received: from 147.122-130-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.130.122.147]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 03 Feb 2019 18:58:49 +0100 Message-ID: <1549216729.2630.17.camel@skynet.be> Subject: Re: [RFA] Fix splay tree KEY leak detected in GDB test gdb.base/macscp.exp From: Philippe Waroquiers To: Kevin Buettner Cc: gdb-patches@sourceware.org Date: Sun, 03 Feb 2019 17:58:00 -0000 In-Reply-To: <20190203104539.6272f9d8@f29-4.lan> References: <20190126223435.9411-1-philippe.waroquiers@skynet.be> <20190203104539.6272f9d8@f29-4.lan> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00013.txt.bz2 Thanks for looking at this. The below change was discussed with Tom on irc. Tom pushed a first fix in the splay tree, so it would be easier for me if he (or someone else) could also push this one. Thanks Philippe On Sun, 2019-02-03 at 10:45 -0700, Kevin Buettner wrote: > On Sat, 26 Jan 2019 23:34:35 +0100 > Philippe Waroquiers wrote: > > > include/ChangeLog > > 2019-01-26 Philippe Waroquiers > > > > * splay-tree.h (splay_tree_delete_key_fn): Update comment. > > (splay_tree_delete_value_fn): Likewise. > > > > libiberty/ChangeLog > > 2019-01-26 Philippe Waroquiers > > > > * splay-tree.c (splay_tree_insert): Also release old KEY in case > > of insertion of a key equal to an already present key. > > (splay_tree_new_typed_alloc): Update comment. > > These changes look reasonable to me, BUT... > > I think you'll need to get approval for this patch from the gcc > maintainers. The libiberty README file indicates that fixes should be > sent to gcc-patches@gcc.gnu.org. > > Kevin