From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53956 invoked by alias); 1 Feb 2019 18:54:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53948 invoked by uid 89); 1 Feb 2019 18:54:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:be, HContent-Transfer-Encoding:8bit X-HELO: mailsec102.isp.belgacom.be Received: from mailsec102.isp.belgacom.be (HELO mailsec102.isp.belgacom.be) (195.238.20.98) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Feb 2019 18:54:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1549047249; x=1580583249; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=iB92e8xXcLlrqgy/eWYMdlxhvf3SSOx+6lUGtJrxDaU=; b=YdiMIqDH/i+qE9e8WTpheMvpmgcbq0VbjafMdBuL/OmrP/cCi9MXPAFj jQighW5PbARaVKdW7kBl0dD0GsxpTw==; Received: from 147.122-130-109.adsl-dyn.isp.belgacom.be (HELO md) ([109.130.122.147]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 01 Feb 2019 19:54:06 +0100 Message-ID: <1549047248.2630.7.camel@skynet.be> Subject: Re: [PATCH] Readline: Cleanup some warnings From: Philippe Waroquiers To: Tom Tromey , Joel Brobecker Cc: Alan Hayward , "gdb-patches@sourceware.org" , nd Date: Fri, 01 Feb 2019 18:54:00 -0000 In-Reply-To: <877eejvfoq.fsf@tromey.com> References: <20190130085716.75179-1-alan.hayward@arm.com> <20190131075907.GA313@adacore.com> <3463805B-A8BF-4C20-ACE3-C21AE3F7DB62@arm.com> <20190201080533.GA31043@adacore.com> <877eejvfoq.fsf@tromey.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00006.txt.bz2 On Fri, 2019-02-01 at 05:47 -0700, Tom Tromey wrote: > > > > > > "Joel" == Joel Brobecker writes: > > Joel> Thank you. It's always better if it is an exact backport, because > Joel> it facilitates future resyncs with the upstream versions. > > Speaking of, I still have a branch with a newer import on it. It could > use some more testing. It's been a while since I poked at this, so I > don't really remember, but I think it fails a couple of gdb tests. So, > some readline debugging is also needed. To solve a leak, I now configure/build GDB to use the debian stable readline, and I only have one more test failing compared to the GDB 6.2: "This 'by design' leak is fixed in readline 7, while the GDB readline version is 6.2 according to the last 'import' message in readline ChangeLog.gdb. On my system (debian 9.6), the leaks are fixed by using    --with-system-readline=yes with the system readline version being 7.0-3 Switching to this readline version causes the following checks to fail: FAIL: gdb.gdb/selftest.exp: send SIGINT signal to child process (timeout) FAIL: gdb.gdb/selftest.exp: thread 1 (timeout) FAIL: gdb.gdb/selftest.exp: backtrace through signal handler (timeout) Apart of that, no problem seen." Philippe