From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42433 invoked by alias); 9 Jan 2019 03:35:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42299 invoked by uid 89); 9 Jan 2019 03:35:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mailsec106.isp.belgacom.be Received: from mailsec106.isp.belgacom.be (HELO mailsec106.isp.belgacom.be) (195.238.20.102) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Jan 2019 03:35:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skynet.be; i=@skynet.be; q=dns/txt; s=securemail; t=1547004914; x=1578540914; h=message-id:subject:from:to:date:in-reply-to:references: mime-version:content-transfer-encoding; bh=jSOC6fTeYc/jwouGchGqhzeHfJdMFaC815n+PZihifA=; b=I+CKH66v9LBBCDqHjQx1KjgrrYaXbB035KU72Jw/DIKNNa/WX+wHpQbl 1ZB/GnQyIqIXfI2SAj2Qp/AtssPXGw==; Received: from 184.205-67-87.adsl-dyn.isp.belgacom.be (HELO md) ([87.67.205.184]) by relay.skynet.be with ESMTP/TLS/AES256-GCM-SHA384; 09 Jan 2019 04:35:12 +0100 Message-ID: <1547004911.1500.6.camel@skynet.be> Subject: Re: [RFA] Fix leak in linespec.c From: Philippe Waroquiers To: Simon Marchi , "gdb-patches@sourceware.org" , Tom Tromey Date: Wed, 09 Jan 2019 03:35:00 -0000 In-Reply-To: <2c12aba6-cafa-54e2-9b69-96d95b82d3fb@ericsson.com> References: <20190108062452.3942-1-philippe.waroquiers@skynet.be> <2c12aba6-cafa-54e2-9b69-96d95b82d3fb@ericsson.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00171.txt.bz2 On Tue, 2019-01-08 at 23:39 +0000, Simon Marchi wrote: > ... so you are adding the equivalent of the first cleanup. > > It would be nice to be able to free the suffix strings in linespec_state_destructor, the > only problem is that we don't know the size of the canonical_names array at that point. > > Anyway, LGTM, thanks! > > Simon Thanks, pushed. Philippe